Re: [PATCH v2 01/12] vhost-user-blk: fix blkcfg->num_queues endianness

2021-01-20 Thread Michael S. Tsirkin
On Mon, Dec 07, 2020 at 05:20:19PM +, Stefan Hajnoczi wrote: > Treat the num_queues field as virtio-endian. On big-endian hosts the > vhost-user-blk num_queues field was in the wrong endianness. > > Move the blkcfg.num_queues store operation from realize to > vhost_user_blk_update_config() so

Re: [PATCH v2 01/12] vhost-user-blk: fix blkcfg->num_queues endianness

2021-01-03 Thread Raphael Norwitz
Apologies for the late review - will get to the rest of the series as soon as I can. On Mon, Dec 7, 2020 at 12:31 PM Stefan Hajnoczi wrote: > > Treat the num_queues field as virtio-endian. On big-endian hosts the > vhost-user-blk num_queues field was in the wrong endianness. > > Move the

[PATCH v2 01/12] vhost-user-blk: fix blkcfg->num_queues endianness

2020-12-07 Thread Stefan Hajnoczi
Treat the num_queues field as virtio-endian. On big-endian hosts the vhost-user-blk num_queues field was in the wrong endianness. Move the blkcfg.num_queues store operation from realize to vhost_user_blk_update_config() so feature negotiation has finished and we know the endianness of the device.