Peter Maydell writes:
> On Fri, 14 Feb 2020 at 17:18, Markus Armbruster wrote:
>> I decided I prefer this as a separate patch, between PATCH 01 and 02.
>>
>> Hmm, maybe I should squash the last hunk into PATCH 01.
>>
>>
>> From 10d174a9f811708807fb60a610e88084f282c222 Mon Sep 17 00:00:00 2001
On Fri, 14 Feb 2020 at 17:18, Markus Armbruster wrote:
> I decided I prefer this as a separate patch, between PATCH 01 and 02.
>
> Hmm, maybe I should squash the last hunk into PATCH 01.
>
>
> From 10d174a9f811708807fb60a610e88084f282c222 Mon Sep 17 00:00:00 2001
> From: Markus Armbruster
>
Peter Maydell writes:
> On Fri, 14 Feb 2020 at 12:20, Markus Armbruster wrote:
>>
>> Peter Maydell writes:
>> >> # Default objcc to clang if available, otherwise use CC
>> >> @@ -4803,7 +4816,7 @@ has_sphinx_build() {
>> >> # sphinx-build doesn't exist at all or if it is too old.
>> >>
On Fri, 14 Feb 2020 at 12:20, Markus Armbruster wrote:
>
> Peter Maydell writes:
> >> # Default objcc to clang if available, otherwise use CC
> >> @@ -4803,7 +4816,7 @@ has_sphinx_build() {
> >> # sphinx-build doesn't exist at all or if it is too old.
> >> mkdir -p "$TMPDIR1/sphinx"
>
Peter Maydell writes:
> On Fri, 14 Feb 2020 at 06:33, Markus Armbruster wrote:
>>
>> Does not work out of the box on my Fedora 30 build host, where
>> sphinx-build gives me sphinx-build-2. I have to specify
>> --sphinx-build=/usr/bin/sphinx-build-3 to unbreak it. Which of course
>> breaks
On Fri, 14 Feb 2020 at 06:33, Markus Armbruster wrote:
>
> Does not work out of the box on my Fedora 30 build host, where
> sphinx-build gives me sphinx-build-2. I have to specify
> --sphinx-build=/usr/bin/sphinx-build-3 to unbreak it. Which of course
> breaks things when I try to build
Does not work out of the box on my Fedora 30 build host, where
sphinx-build gives me sphinx-build-2. I have to specify
--sphinx-build=/usr/bin/sphinx-build-3 to unbreak it. Which of course
breaks things when I try to build anything before this commit
The appended patch makes it work out of the
Currently we insist on using 'sphinx-build' from the $PATH;
allow the user to specify the binary to use. This will be
more useful as we become pickier about the capabilities
we require (eg needing a Python 3 sphinx-build).
Signed-off-by: Peter Maydell
Reviewed-by: Alex Bennée
Reviewed-by:
