Re: [PATCH v2 01/39] tests: Change to use g_mkdir()

2022-09-26 Thread Daniel P . Berrangé
On Fri, Sep 23, 2022 at 08:02:46PM +0200, Thomas Huth wrote: > On 23/09/2022 03.09, Bin Meng wrote: > > On Fri, Sep 23, 2022 at 3:32 AM Marc-André Lureau > > wrote: > > > > > > Hi > > > > > > On Tue, Sep 20, 2022 at 1:48 PM Bin Meng wrote: > > > > > > > > From: Bin Meng > > > > > > > >

Re: [PATCH v2 01/39] tests: Change to use g_mkdir()

2022-09-23 Thread Thomas Huth
On 23/09/2022 03.09, Bin Meng wrote: On Fri, Sep 23, 2022 at 3:32 AM Marc-André Lureau wrote: Hi On Tue, Sep 20, 2022 at 1:48 PM Bin Meng wrote: From: Bin Meng Commit 413bebc04603 ("tests: Use g_mkdir_with_parents()") replaces the mkdir() call in the test codes with glib's

Re: [PATCH v2 01/39] tests: Change to use g_mkdir()

2022-09-22 Thread Bin Meng
On Fri, Sep 23, 2022 at 3:32 AM Marc-André Lureau wrote: > > Hi > > On Tue, Sep 20, 2022 at 1:48 PM Bin Meng wrote: >> >> From: Bin Meng >> >> Commit 413bebc04603 ("tests: Use g_mkdir_with_parents()") replaces >> the mkdir() call in the test codes with glib's g_mkdir_with_parents(), >> but the

Re: [PATCH v2 01/39] tests: Change to use g_mkdir()

2022-09-22 Thread Marc-André Lureau
Hi On Tue, Sep 20, 2022 at 1:48 PM Bin Meng wrote: > From: Bin Meng > > Commit 413bebc04603 ("tests: Use g_mkdir_with_parents()") replaces > the mkdir() call in the test codes with glib's g_mkdir_with_parents(), > but the exact portable replacement for mkdir() should be g_mkdir(). > > I

[PATCH v2 01/39] tests: Change to use g_mkdir()

2022-09-20 Thread Bin Meng
From: Bin Meng Commit 413bebc04603 ("tests: Use g_mkdir_with_parents()") replaces the mkdir() call in the test codes with glib's g_mkdir_with_parents(), but the exact portable replacement for mkdir() should be g_mkdir(). I probably was misled by the GTK glib doc [1] before, thinking that