Re: [PATCH v2 02/12] tests/docker: better handle symlinked libs

2020-01-31 Thread Alex Bennée
Philippe Mathieu-Daudé writes: > On 1/30/20 12:32 PM, Alex Bennée wrote: >> When we are copying we want to ensure we grab the first >> resolution (the found in path section). However even that binary might >> be a symlink so lets make sure we chase the symlinks to copy the right >> binary to

Re: [PATCH v2 02/12] tests/docker: better handle symlinked libs

2020-01-31 Thread Philippe Mathieu-Daudé
On 1/30/20 12:32 PM, Alex Bennée wrote: When we are copying we want to ensure we grab the first resolution (the found in path section). However even that binary might be a symlink so lets make sure we chase the symlinks to copy the right binary to where it can be found. Signed-off-by: Alex

Re: [PATCH v2 02/12] tests/docker: better handle symlinked libs

2020-01-30 Thread Philippe Mathieu-Daudé
On 1/30/20 3:37 PM, Robert Foley wrote: Hi, I was looking at this patch and have a comment about the number of groups that are expected to be found by this regex. It seems like the old code expected two groups to be found otherwise it will not append the library to the found libs. def

Re: [PATCH v2 02/12] tests/docker: better handle symlinked libs

2020-01-30 Thread Robert Foley
Hi, I was looking at this patch and have a comment about the number of groups that are expected to be found by this regex. It seems like the old code expected two groups to be found otherwise it will not append the library to the found libs. def _get_so_libs(executable): libs = [] ldd_re =

[PATCH v2 02/12] tests/docker: better handle symlinked libs

2020-01-30 Thread Alex Bennée
When we are copying we want to ensure we grab the first resolution (the found in path section). However even that binary might be a symlink so lets make sure we chase the symlinks to copy the right binary to where it can be found. Signed-off-by: Alex Bennée --- tests/docker/docker.py | 5 +++--