Re: [PATCH v2 03/19] qapi: create QAPISchemaDefinition

2024-01-16 Thread John Snow
On Tue, Jan 16, 2024 at 2:22 AM Markus Armbruster wrote: > > John Snow writes: > > > On Mon, Jan 15, 2024 at 8:16 AM Markus Armbruster wrote: > >> > >> John Snow writes: > >> > >> > Include entities don't have names, but we generally expect "entities" to > >> > have names. Reclassify all entiti

Re: [PATCH v2 03/19] qapi: create QAPISchemaDefinition

2024-01-15 Thread Markus Armbruster
John Snow writes: > On Mon, Jan 15, 2024 at 8:16 AM Markus Armbruster wrote: >> >> John Snow writes: >> >> > Include entities don't have names, but we generally expect "entities" to >> > have names. Reclassify all entities with names as *definitions*, leaving >> > the nameless include entities

Re: [PATCH v2 03/19] qapi: create QAPISchemaDefinition

2024-01-15 Thread John Snow
On Mon, Jan 15, 2024 at 8:16 AM Markus Armbruster wrote: > > John Snow writes: > > > Include entities don't have names, but we generally expect "entities" to > > have names. Reclassify all entities with names as *definitions*, leaving > > the nameless include entities as QAPISchemaEntity instance

[PATCH v2 03/19] qapi: create QAPISchemaDefinition

2024-01-12 Thread John Snow
Include entities don't have names, but we generally expect "entities" to have names. Reclassify all entities with names as *definitions*, leaving the nameless include entities as QAPISchemaEntity instances. This is primarily to help simplify typing around expectations of what callers expect for pr