Re: [PATCH v2 04/21] qapi/parser: factor parsing routine into method

2021-05-18 Thread John Snow
On 5/18/21 5:57 AM, Markus Armbruster wrote: John Snow writes: For the sake of keeping __init__ smaller (and treating it more like a gallery of what state variables we can expect to see), put the actual parsing action into a parse method. It remains invoked from the init method to reduce

Re: [PATCH v2 04/21] qapi/parser: factor parsing routine into method

2021-05-18 Thread Markus Armbruster
John Snow writes: > For the sake of keeping __init__ smaller (and treating it more like a > gallery of what state variables we can expect to see), put the actual > parsing action into a parse method. It remains invoked from the init > method to reduce churn. I'm kind of *shrug* about this.

[PATCH v2 04/21] qapi/parser: factor parsing routine into method

2021-05-11 Thread John Snow
For the sake of keeping __init__ smaller (and treating it more like a gallery of what state variables we can expect to see), put the actual parsing action into a parse method. It remains invoked from the init method to reduce churn. To accomplish this, 'previously_included' becomes the private