Re: [PATCH v2 05/11] qemu-options: finesse the recommendations around -blockdev

2023-04-11 Thread Alex Bennée
Kevin Wolf writes: > Am 06.04.2023 um 22:23 hat Reinoud Zandijk geschrieben: >> On Tue, Apr 04, 2023 at 06:17:45PM +0200, Kevin Wolf wrote: >> > Am 04.04.2023 um 17:07 hat Michael Tokarev geschrieben: >> > > 04.04.2023 16:57, Kevin Wolf пишет: >> > Maybe -snapshot should error out if -blockdev

Re: [PATCH v2 05/11] qemu-options: finesse the recommendations around -blockdev

2023-04-11 Thread Kevin Wolf
Am 06.04.2023 um 22:23 hat Reinoud Zandijk geschrieben: > On Tue, Apr 04, 2023 at 06:17:45PM +0200, Kevin Wolf wrote: > > Am 04.04.2023 um 17:07 hat Michael Tokarev geschrieben: > > > 04.04.2023 16:57, Kevin Wolf пишет: > > Maybe -snapshot should error out if -blockdev is in use. You'd generally >

Re: [PATCH v2 05/11] qemu-options: finesse the recommendations around -blockdev

2023-04-06 Thread Reinoud Zandijk
On Tue, Apr 04, 2023 at 06:17:45PM +0200, Kevin Wolf wrote: > Am 04.04.2023 um 17:07 hat Michael Tokarev geschrieben: > > 04.04.2023 16:57, Kevin Wolf пишет: > Maybe -snapshot should error out if -blockdev is in use. You'd generally > expect that either -blockdev is used primarily and snapshots

Re: [PATCH v2 05/11] qemu-options: finesse the recommendations around -blockdev

2023-04-04 Thread Kevin Wolf
Am 04.04.2023 um 17:07 hat Michael Tokarev geschrieben: > 04.04.2023 16:57, Kevin Wolf пишет: > > Let's not make the use of -drive look more advisable than it really is. > > If you're writing a management tool/script and you're still using -drive > > today, you're doing it wrong. > > Kevin, maybe

Re: [PATCH v2 05/11] qemu-options: finesse the recommendations around -blockdev

2023-04-04 Thread Michael Tokarev
04.04.2023 16:57, Kevin Wolf пишет: Let's not make the use of -drive look more advisable than it really is. If you're writing a management tool/script and you're still using -drive today, you're doing it wrong. Kevin, maybe I'm wrong here, but what to do with the situation which started it

Re: [PATCH v2 05/11] qemu-options: finesse the recommendations around -blockdev

2023-04-04 Thread Alex Bennée
Kevin Wolf writes: > Am 03.04.2023 um 15:49 hat Alex Bennée geschrieben: >> We are a bit premature in recommending -blockdev/-device as the best >> way to configure block devices, especially in the common case. >> Improve the language to hopefully make things clearer. >> >> Suggested-by:

Re: [PATCH v2 05/11] qemu-options: finesse the recommendations around -blockdev

2023-04-04 Thread Kevin Wolf
Am 03.04.2023 um 15:49 hat Alex Bennée geschrieben: > We are a bit premature in recommending -blockdev/-device as the best > way to configure block devices, especially in the common case. > Improve the language to hopefully make things clearer. > > Suggested-by: Michael Tokarev > Signed-off-by:

[PATCH v2 05/11] qemu-options: finesse the recommendations around -blockdev

2023-04-03 Thread Alex Bennée
We are a bit premature in recommending -blockdev/-device as the best way to configure block devices, especially in the common case. Improve the language to hopefully make things clearer. Suggested-by: Michael Tokarev Signed-off-by: Alex Bennée Reviewed-by: Thomas Huth Message-Id: