Re: [PATCH v2 06/12] qapi/source: Add builtin null-object sentinel

2021-01-19 Thread Eduardo Habkost
On Tue, Jan 19, 2021 at 11:21:16AM +0100, Markus Armbruster wrote: > Eduardo Habkost writes: > > > On Thu, Jan 14, 2021 at 02:39:35PM +0100, Markus Armbruster wrote: > >> John Snow writes: > >> > >> > On 1/13/21 10:39 AM, Markus Armbruster wrote: > >> >> Spelling nitpick: s/builtin/built-in/

Re: [PATCH v2 06/12] qapi/source: Add builtin null-object sentinel

2021-01-19 Thread Markus Armbruster
Eduardo Habkost writes: > On Thu, Jan 14, 2021 at 02:39:35PM +0100, Markus Armbruster wrote: >> John Snow writes: >> >> > On 1/13/21 10:39 AM, Markus Armbruster wrote: >> >> Spelling nitpick: s/builtin/built-in/ in the title. >> >> >> > >> > Sure. >> > >> >> John Snow writes: >> >> >> >>>

Re: [PATCH v2 06/12] qapi/source: Add builtin null-object sentinel

2021-01-18 Thread Eduardo Habkost
On Thu, Jan 14, 2021 at 02:39:35PM +0100, Markus Armbruster wrote: > John Snow writes: > > > On 1/13/21 10:39 AM, Markus Armbruster wrote: > >> Spelling nitpick: s/builtin/built-in/ in the title. > >> > > > > Sure. > > > >> John Snow writes: > >> > >>> We use None to represent an object that

Re: [PATCH v2 06/12] qapi/source: Add builtin null-object sentinel

2021-01-14 Thread Markus Armbruster
John Snow writes: > On 1/13/21 10:39 AM, Markus Armbruster wrote: >> Spelling nitpick: s/builtin/built-in/ in the title. >> > > Sure. > >> John Snow writes: >> >>> We use None to represent an object that has no source information >>> because it's a builtin. This complicates interface typing,

Re: [PATCH v2 06/12] qapi/source: Add builtin null-object sentinel

2021-01-13 Thread John Snow
On 1/13/21 10:39 AM, Markus Armbruster wrote: Spelling nitpick: s/builtin/built-in/ in the title. Sure. John Snow writes: We use None to represent an object that has no source information because it's a builtin. This complicates interface typing, since many interfaces expect that there

Re: [PATCH v2 06/12] qapi/source: Add builtin null-object sentinel

2021-01-13 Thread Markus Armbruster
Spelling nitpick: s/builtin/built-in/ in the title. John Snow writes: > We use None to represent an object that has no source information > because it's a builtin. This complicates interface typing, since many > interfaces expect that there is an info object available to print errors > with. >

[PATCH v2 06/12] qapi/source: Add builtin null-object sentinel

2020-12-16 Thread John Snow
We use None to represent an object that has no source information because it's a builtin. This complicates interface typing, since many interfaces expect that there is an info object available to print errors with. Introduce a special QAPISourceInfo that represents these built-ins so that if an