Re: [PATCH v2 06/12] target/ppc: Add PPR32 SPR

2024-05-21 Thread Nicholas Piggin
On Wed May 22, 2024 at 3:40 AM AEST, Richard Henderson wrote: > On 5/20/24 18:30, Nicholas Piggin wrote: > > +void spr_write_ppr32(DisasContext *ctx, int sprn, int gprn) > > +{ > > +TCGv t0 = tcg_temp_new(); > > + > > +tcg_gen_shli_tl(t0, cpu_gpr[gprn], 32); > > +gen_store_spr(SPR_PPR,

Re: [PATCH v2 06/12] target/ppc: Add PPR32 SPR

2024-05-21 Thread Richard Henderson
On 5/20/24 18:30, Nicholas Piggin wrote: +void spr_write_ppr32(DisasContext *ctx, int sprn, int gprn) +{ +TCGv t0 = tcg_temp_new(); + +tcg_gen_shli_tl(t0, cpu_gpr[gprn], 32); +gen_store_spr(SPR_PPR, t0); +spr_store_dump_spr(SPR_PPR); +} The documentation isn't clear on whether

Re: [PATCH v2 06/12] target/ppc: Add PPR32 SPR

2024-05-21 Thread Miles Glenn
Reviewed-by: Glenn Miles Thanks, Glenn On Tue, 2024-05-21 at 11:30 +1000, Nicholas Piggin wrote: > PPR32 provides access to the upper half of PPR. > > Signed-off-by: Nicholas Piggin > --- > target/ppc/cpu.h| 1 + > target/ppc/spr_common.h | 2 ++ > target/ppc/cpu_init.c | 12

[PATCH v2 06/12] target/ppc: Add PPR32 SPR

2024-05-20 Thread Nicholas Piggin
PPR32 provides access to the upper half of PPR. Signed-off-by: Nicholas Piggin --- target/ppc/cpu.h| 1 + target/ppc/spr_common.h | 2 ++ target/ppc/cpu_init.c | 12 target/ppc/translate.c | 16 4 files changed, 31 insertions(+) diff --git