Re: [PATCH v2 06/21] migration: Add Error** argument to .save_setup() handler

2024-03-01 Thread Vladimir Sementsov-Ogievskiy
On 01.03.24 17:44, Vladimir Sementsov-Ogievskiy wrote: On 29.02.24 16:21, Markus Armbruster wrote: Thomas Huth writes: On 29/02/2024 08.20, Vladimir Sementsov-Ogievskiy wrote: On 29.02.24 09:32, Markus Armbruster wrote: [...] Anti-pattern: fail without setting an error.  There might be

Re: [PATCH v2 06/21] migration: Add Error** argument to .save_setup() handler

2024-03-01 Thread Vladimir Sementsov-Ogievskiy
On 29.02.24 16:21, Markus Armbruster wrote: Thomas Huth writes: On 29/02/2024 08.20, Vladimir Sementsov-Ogievskiy wrote: On 29.02.24 09:32, Markus Armbruster wrote: [...] Anti-pattern: fail without setting an error.  There might be more elsewhere in the series. qapi/error.h's big

Re: [PATCH v2 06/21] migration: Add Error** argument to .save_setup() handler

2024-02-29 Thread Cédric Le Goater
On 2/29/24 07:32, Markus Armbruster wrote: Cédric Le Goater writes: The purpose is to record a potential error in the migration stream if qemu_savevm_state_setup() fails. Most of the current .save_setup() handlers can be modified to use the Error argument instead of managing their own and

Re: [PATCH v2 06/21] migration: Add Error** argument to .save_setup() handler

2024-02-29 Thread Markus Armbruster
Thomas Huth writes: > On 29/02/2024 08.20, Vladimir Sementsov-Ogievskiy wrote: >> On 29.02.24 09:32, Markus Armbruster wrote: [...] >>> Anti-pattern: fail without setting an error.  There might be more >>> elsewhere in the series. >>> >>> qapi/error.h's big comment: >>> >>>   * - On success,

Re: [PATCH v2 06/21] migration: Add Error** argument to .save_setup() handler

2024-02-29 Thread Thomas Huth
On 29/02/2024 08.20, Vladimir Sementsov-Ogievskiy wrote: On 29.02.24 09:32, Markus Armbruster wrote: Cédric Le Goater writes: The purpose is to record a potential error in the migration stream if qemu_savevm_state_setup() fails. Most of the current .save_setup() handlers can be modified to

Re: [PATCH v2 06/21] migration: Add Error** argument to .save_setup() handler

2024-02-28 Thread Vladimir Sementsov-Ogievskiy
On 29.02.24 09:32, Markus Armbruster wrote: Cédric Le Goater writes: The purpose is to record a potential error in the migration stream if qemu_savevm_state_setup() fails. Most of the current .save_setup() handlers can be modified to use the Error argument instead of managing their own and

Re: [PATCH v2 06/21] migration: Add Error** argument to .save_setup() handler

2024-02-28 Thread Markus Armbruster
Cédric Le Goater writes: > The purpose is to record a potential error in the migration stream if > qemu_savevm_state_setup() fails. Most of the current .save_setup() > handlers can be modified to use the Error argument instead of managing > their own and calling locally error_report(). The

[PATCH v2 06/21] migration: Add Error** argument to .save_setup() handler

2024-02-27 Thread Cédric Le Goater
The purpose is to record a potential error in the migration stream if qemu_savevm_state_setup() fails. Most of the current .save_setup() handlers can be modified to use the Error argument instead of managing their own and calling locally error_report(). The following patches will introduce such