Re: [PATCH v2 09/18] qga: Fix guest-get-fsinfo error API violations

On 12/4/19 10:36 AM, Markus Armbruster wrote: build_guest_fsinfo_for_virtual_device() dereferences @errp when build_guest_fsinfo_for_device() fails. That's wrong; see the big comment in error.h. Introduced in commit 46d4c5723e "qga: Add guest-get-fsinfo command". No caller actually passes

[PATCH v2 09/18] qga: Fix guest-get-fsinfo error API violations

build_guest_fsinfo_for_virtual_device() dereferences @errp when build_guest_fsinfo_for_device() fails. That's wrong; see the big comment in error.h. Introduced in commit 46d4c5723e "qga: Add guest-get-fsinfo command". No caller actually passes null. Fix anyway: splice in a local Error *err,