Re: [PATCH v2 09/30] tcg/loongarch64: Implement tcg_out_mov and tcg_out_movi

2021-09-22 Thread WANG Xuerui
Hi Richard, On 9/22/21 23:17, Richard Henderson wrote: On 9/22/21 8:16 AM, WANG Xuerui wrote: Hi Richard, On 9/22/21 12:25, Richard Henderson wrote: On 9/21/21 1:18 PM, WANG Xuerui wrote: +    /* Test for PC-relative values that can be loaded faster.  */ +    intptr_t pc_offset = val -

Re: [PATCH v2 09/30] tcg/loongarch64: Implement tcg_out_mov and tcg_out_movi

2021-09-22 Thread Richard Henderson
On 9/22/21 8:16 AM, WANG Xuerui wrote: Hi Richard, On 9/22/21 12:25, Richard Henderson wrote: On 9/21/21 1:18 PM, WANG Xuerui wrote: +    /* Test for PC-relative values that can be loaded faster.  */ +    intptr_t pc_offset = val - (uintptr_t)s->code_ptr; This isn't quite right for split

Re: [PATCH v2 09/30] tcg/loongarch64: Implement tcg_out_mov and tcg_out_movi

2021-09-22 Thread WANG Xuerui
Hi Richard, On 9/22/21 12:25, Richard Henderson wrote: On 9/21/21 1:18 PM, WANG Xuerui wrote: +    /* Test for PC-relative values that can be loaded faster.  */ +    intptr_t pc_offset = val - (uintptr_t)s->code_ptr; This isn't quite right for split r^x code buffer. You should have seen this

Re: [PATCH v2 09/30] tcg/loongarch64: Implement tcg_out_mov and tcg_out_movi

2021-09-21 Thread Richard Henderson
On 9/21/21 1:18 PM, WANG Xuerui wrote: +/* Test for PC-relative values that can be loaded faster. */ +intptr_t pc_offset = val - (uintptr_t)s->code_ptr; This isn't quite right for split r^x code buffer. You should have seen this with --enable-debug-tcg... You need pc_offset =

[PATCH v2 09/30] tcg/loongarch64: Implement tcg_out_mov and tcg_out_movi

2021-09-21 Thread WANG Xuerui
Signed-off-by: WANG Xuerui --- tcg/loongarch64/tcg-target.c.inc | 89 1 file changed, 89 insertions(+) diff --git a/tcg/loongarch64/tcg-target.c.inc b/tcg/loongarch64/tcg-target.c.inc index 338b772732..e4e7e5e903 100644 --- a/tcg/loongarch64/tcg-target.c.inc +++