Re: [PATCH v2 1/1] migration/dirtyrate: Fix segmentation fault

2024-04-28 Thread Yong Huang
On Wed, Apr 24, 2024 at 3:17 PM Zhijian Li (Fujitsu) wrote: > > > On 24/04/2024 12:52, mii wrote: > > > > On 2024/04/24 10:28, Yong Huang wrote: > >> > >> > >> On Tue, Apr 23, 2024 at 9:35 PM Peter Xu wrote: > >> > >> On Tue, Apr 23, 2024 at 09:13:08AM +, Masato Imai wrote: > >> >

Re: [PATCH v2 1/1] migration/dirtyrate: Fix segmentation fault

2024-04-24 Thread Zhijian Li (Fujitsu)
On 24/04/2024 12:52, mii wrote: > > On 2024/04/24 10:28, Yong Huang wrote: >> >> >> On Tue, Apr 23, 2024 at 9:35 PM Peter Xu wrote: >> >> On Tue, Apr 23, 2024 at 09:13:08AM +, Masato Imai wrote: >> > When the KVM acceleration parameter is not set, executing >> calc_dirty_rate >>

Re: [PATCH v2 1/1] migration/dirtyrate: Fix segmentation fault

2024-04-23 Thread mii
On 2024/04/24 10:28, Yong Huang wrote: On Tue, Apr 23, 2024 at 9:35 PM Peter Xu wrote: On Tue, Apr 23, 2024 at 09:13:08AM +, Masato Imai wrote: > When the KVM acceleration parameter is not set, executing calc_dirty_rate > with the -r or -b option results in a

Re: [PATCH v2 1/1] migration/dirtyrate: Fix segmentation fault

2024-04-23 Thread Yong Huang
On Tue, Apr 23, 2024 at 9:35 PM Peter Xu wrote: > On Tue, Apr 23, 2024 at 09:13:08AM +, Masato Imai wrote: > > When the KVM acceleration parameter is not set, executing calc_dirty_rate > > with the -r or -b option results in a segmentation fault due to accessing > > a null kvm_state pointer

Re: [PATCH v2 1/1] migration/dirtyrate: Fix segmentation fault

2024-04-23 Thread Peter Xu
On Tue, Apr 23, 2024 at 09:13:08AM +, Masato Imai wrote: > When the KVM acceleration parameter is not set, executing calc_dirty_rate > with the -r or -b option results in a segmentation fault due to accessing > a null kvm_state pointer in the kvm_dirty_ring_enabled function. > This commit adds

[PATCH v2 1/1] migration/dirtyrate: Fix segmentation fault

2024-04-23 Thread Masato Imai
When the KVM acceleration parameter is not set, executing calc_dirty_rate with the -r or -b option results in a segmentation fault due to accessing a null kvm_state pointer in the kvm_dirty_ring_enabled function. This commit adds a check for kvm_enabled to prevent segmentation faults.