Re: [PATCH v2 1/1] virtio: fix the condition for iommu_platform not supported

2022-01-28 Thread Daniel Henrique Barboza
On 1/28/22 08:48, Halil Pasic wrote: On Fri, 28 Jan 2022 08:02:39 -0300 Daniel Henrique Barboza wrote: We may be able to differentiate between the two using ->dma_as, but for that it needs to be set up correctly: whenever you require translation it should be something different than address

Re: [PATCH v2 1/1] virtio: fix the condition for iommu_platform not supported

2022-01-28 Thread Michael S. Tsirkin
On Fri, Jan 28, 2022 at 08:02:39AM -0300, Daniel Henrique Barboza wrote: > > > On 1/27/22 23:29, Halil Pasic wrote: > > On Thu, 27 Jan 2022 18:34:23 -0300 > > Daniel Henrique Barboza wrote: > > > > > On 1/27/22 10:28, Halil Pasic wrote: > > > > ping^2 > > > > > > > > Also adding Brijesh and Da

Re: [PATCH v2 1/1] virtio: fix the condition for iommu_platform not supported

2022-01-28 Thread Halil Pasic
On Fri, 28 Jan 2022 08:02:39 -0300 Daniel Henrique Barboza wrote: > > We may be able to differentiate between the two using ->dma_as, but for > > that it needs to be set up correctly: whenever you require translation > > it should be something different than address_space_memory. The question > >

Re: [PATCH v2 1/1] virtio: fix the condition for iommu_platform not supported

2022-01-28 Thread Daniel Henrique Barboza
On 1/27/22 23:29, Halil Pasic wrote: On Thu, 27 Jan 2022 18:34:23 -0300 Daniel Henrique Barboza wrote: On 1/27/22 10:28, Halil Pasic wrote: ping^2 Also adding Brijesh and Daniel, as I believe you guys should be interested in this, and I'm yet to receive review. @Brijesh, Daniel: Can you

Re: [PATCH v2 1/1] virtio: fix the condition for iommu_platform not supported

2022-01-28 Thread Michael S. Tsirkin
On Fri, Jan 28, 2022 at 03:29:11AM +0100, Halil Pasic wrote: > On Thu, 27 Jan 2022 18:34:23 -0300 > Daniel Henrique Barboza wrote: > > > On 1/27/22 10:28, Halil Pasic wrote: > > > ping^2 > > > > > > Also adding Brijesh and Daniel, as I believe you guys should be > > > interested in this, and I'm

Re: [PATCH v2 1/1] virtio: fix the condition for iommu_platform not supported

2022-01-27 Thread Halil Pasic
On Thu, 27 Jan 2022 18:34:23 -0300 Daniel Henrique Barboza wrote: > On 1/27/22 10:28, Halil Pasic wrote: > > ping^2 > > > > Also adding Brijesh and Daniel, as I believe you guys should be > > interested in this, and I'm yet to receive review. > > > > @Brijesh, Daniel: Can you confirm that AMD (

Re: [PATCH v2 1/1] virtio: fix the condition for iommu_platform not supported

2022-01-27 Thread Daniel Henrique Barboza
On 1/27/22 10:28, Halil Pasic wrote: ping^2 Also adding Brijesh and Daniel, as I believe you guys should be interested in this, and I'm yet to receive review. @Brijesh, Daniel: Can you confirm that AMD (SEV) and Power are affected too, and that the fix works for your platforms as well? I f

Re: [PATCH v2 1/1] virtio: fix the condition for iommu_platform not supported

2022-01-27 Thread Brijesh Singh
On 1/27/22 7:28 AM, Halil Pasic wrote: ping^2 Also adding Brijesh and Daniel, as I believe you guys should be interested in this, and I'm yet to receive review. @Brijesh, Daniel: Can you confirm that AMD (SEV) and Power are affected too, and that the fix works for your platforms as well?

Re: [PATCH v2 1/1] virtio: fix the condition for iommu_platform not supported

2022-01-27 Thread Halil Pasic
ping^2 Also adding Brijesh and Daniel, as I believe you guys should be interested in this, and I'm yet to receive review. @Brijesh, Daniel: Can you confirm that AMD (SEV) and Power are affected too, and that the fix works for your platforms as well? Regards, Halil On Tue, 25 Jan 2022 11:21:12 +

Re: [PATCH v2 1/1] virtio: fix the condition for iommu_platform not supported

2022-01-25 Thread Halil Pasic
ping On Mon, 17 Jan 2022 13:02:38 +0100 Halil Pasic wrote: > The commit 04ceb61a40 ("virtio: Fail if iommu_platform is requested, but > unsupported") claims to fail the device hotplug when iommu_platform > is requested, but not supported by the (vhost) device. On the first > glance the condition

[PATCH v2 1/1] virtio: fix the condition for iommu_platform not supported

2022-01-17 Thread Halil Pasic
The commit 04ceb61a40 ("virtio: Fail if iommu_platform is requested, but unsupported") claims to fail the device hotplug when iommu_platform is requested, but not supported by the (vhost) device. On the first glance the condition for detecting that situation looks perfect, but because a certain pec