Re: [PATCH v2 1/1] virtio: write back F_VERSION_1 before validate

2021-10-08 Thread Michael S. Tsirkin
On Fri, Oct 08, 2021 at 03:51:56PM +0200, Halil Pasic wrote: > On Fri, 8 Oct 2021 09:05:03 -0400 > "Michael S. Tsirkin" wrote: > > > On Fri, Oct 08, 2021 at 02:34:22PM +0200, Halil Pasic wrote: > > > The virtio specification virtio-v1.1-cs01 states: "Transitional devices > > > MUST detect Legacy

Re: [PATCH v2 1/1] virtio: write back F_VERSION_1 before validate

2021-10-08 Thread Cornelia Huck
On Fri, Oct 08 2021, Halil Pasic wrote: > On Fri, 8 Oct 2021 09:05:03 -0400 > "Michael S. Tsirkin" wrote: > >> On Fri, Oct 08, 2021 at 02:34:22PM +0200, Halil Pasic wrote: >> > The virtio specification virtio-v1.1-cs01 states: "Transitional devices >> > MUST detect Legacy drivers by detecting th

Re: [PATCH v2 1/1] virtio: write back F_VERSION_1 before validate

2021-10-08 Thread Halil Pasic
On Fri, 8 Oct 2021 09:05:03 -0400 "Michael S. Tsirkin" wrote: > On Fri, Oct 08, 2021 at 02:34:22PM +0200, Halil Pasic wrote: > > The virtio specification virtio-v1.1-cs01 states: "Transitional devices > > MUST detect Legacy drivers by detecting that VIRTIO_F_VERSION_1 has not > > been acknowledge

Re: [PATCH v2 1/1] virtio: write back F_VERSION_1 before validate

2021-10-08 Thread Michael S. Tsirkin
On Fri, Oct 08, 2021 at 02:34:22PM +0200, Halil Pasic wrote: > The virtio specification virtio-v1.1-cs01 states: "Transitional devices > MUST detect Legacy drivers by detecting that VIRTIO_F_VERSION_1 has not > been acknowledged by the driver." This is exactly what QEMU as of 6.1 > has done relyin

[PATCH v2 1/1] virtio: write back F_VERSION_1 before validate

2021-10-08 Thread Halil Pasic
The virtio specification virtio-v1.1-cs01 states: "Transitional devices MUST detect Legacy drivers by detecting that VIRTIO_F_VERSION_1 has not been acknowledged by the driver." This is exactly what QEMU as of 6.1 has done relying solely on VIRTIO_F_VERSION_1 for detecting that. However, the spec