Re: [PATCH v2 1/2] Introduce (x86) CPU model deprecation API

2020-09-15 Thread Eduardo Habkost
On Tue, Sep 15, 2020 at 10:56:06AM +0800, Robert Hoo wrote: > On Mon, 2020-09-14 at 13:38 +, Eduardo Habkost wrote: > > On Mon, Sep 14, 2020 at 06:50:09PM +0800, Robert Hoo wrote: [...] > > > 2) Each x86 cpudef CPU model has 1 unversioned cpu_model_type then > > > its > > > versioned

Re: [PATCH v2 1/2] Introduce (x86) CPU model deprecation API

2020-09-14 Thread Robert Hoo
On Mon, 2020-09-14 at 13:38 +, Eduardo Habkost wrote: > On Mon, Sep 14, 2020 at 06:50:09PM +0800, Robert Hoo wrote: > > On Fri, 2020-09-11 at 10:00 -0400, Eduardo Habkost wrote: > > > On Fri, Sep 11, 2020 at 02:22:51PM +0800, Robert Hoo wrote: > > > > On Wed, 2020-09-09 at 14:15 -0400, Eduardo

Re: [PATCH v2 1/2] Introduce (x86) CPU model deprecation API

2020-09-14 Thread Eduardo Habkost
On Mon, Sep 14, 2020 at 06:50:09PM +0800, Robert Hoo wrote: > On Fri, 2020-09-11 at 10:00 -0400, Eduardo Habkost wrote: > > On Fri, Sep 11, 2020 at 02:22:51PM +0800, Robert Hoo wrote: > > > On Wed, 2020-09-09 at 14:15 -0400, Eduardo Habkost wrote: [...] > > > > > +static void

Re: [PATCH v2 1/2] Introduce (x86) CPU model deprecation API

2020-09-14 Thread Robert Hoo
On Fri, 2020-09-11 at 10:00 -0400, Eduardo Habkost wrote: > On Fri, Sep 11, 2020 at 02:22:51PM +0800, Robert Hoo wrote: > > On Wed, 2020-09-09 at 14:15 -0400, Eduardo Habkost wrote: > > > Hi, > > > > > > > > > > @@ -1129,6 +1130,12 @@ void machine_run_board_init(MachineState > > > > *machine) >

Re: [PATCH v2 1/2] Introduce (x86) CPU model deprecation API

2020-09-11 Thread Eduardo Habkost
On Fri, Sep 11, 2020 at 02:22:51PM +0800, Robert Hoo wrote: > On Wed, 2020-09-09 at 14:15 -0400, Eduardo Habkost wrote: > > Hi, > > > > Thanks for the patch, and sorry for taking so long to review > > this. I'm finally getting to the patches that were postponed to > > 5.2. > > > > Comments and

Re: [PATCH v2 1/2] Introduce (x86) CPU model deprecation API

2020-09-11 Thread Robert Hoo
On Wed, 2020-09-09 at 14:15 -0400, Eduardo Habkost wrote: > Hi, > > Thanks for the patch, and sorry for taking so long to review > this. I'm finally getting to the patches that were postponed to > 5.2. > > Comments and questions below: > > On Thu, Jun 11, 2020 at 10:47:55AM +0800, Robert Hoo

Re: [PATCH v2 1/2] Introduce (x86) CPU model deprecation API

2020-09-10 Thread Philippe Mathieu-Daudé
On 9/10/20 9:12 PM, Eduardo Habkost wrote: > On Thu, Sep 10, 2020 at 07:29:03AM +0200, Philippe Mathieu-Daudé wrote: >> On 9/9/20 8:15 PM, Eduardo Habkost wrote: >>> Hi, >>> >>> Thanks for the patch, and sorry for taking so long to review >>> this. I'm finally getting to the patches that were

Re: [PATCH v2 1/2] Introduce (x86) CPU model deprecation API

2020-09-10 Thread Eduardo Habkost
On Thu, Sep 10, 2020 at 07:29:03AM +0200, Philippe Mathieu-Daudé wrote: > On 9/9/20 8:15 PM, Eduardo Habkost wrote: > > Hi, > > > > Thanks for the patch, and sorry for taking so long to review > > this. I'm finally getting to the patches that were postponed to > > 5.2. > > Sorry I missed that

Re: [PATCH v2 1/2] Introduce (x86) CPU model deprecation API

2020-09-09 Thread Philippe Mathieu-Daudé
On 9/9/20 8:15 PM, Eduardo Habkost wrote: > Hi, > > Thanks for the patch, and sorry for taking so long to review > this. I'm finally getting to the patches that were postponed to > 5.2. Sorry I missed that patch too. Why restrict this to CPUClass, and not provide this feature to all

Re: [PATCH v2 1/2] Introduce (x86) CPU model deprecation API

2020-09-09 Thread Eduardo Habkost
Hi, Thanks for the patch, and sorry for taking so long to review this. I'm finally getting to the patches that were postponed to 5.2. Comments and questions below: On Thu, Jun 11, 2020 at 10:47:55AM +0800, Robert Hoo wrote: > Complement versioned CPU model framework with the ability of marking

Re: [PATCH v2 1/2] Introduce (x86) CPU model deprecation API

2020-06-28 Thread Robert Hoo
Hi, Ping for comments:) On Thu, 2020-06-11 at 10:47 +0800, Robert Hoo wrote: > Complement versioned CPU model framework with the ability of marking > some > versions deprecated. When that CPU model is chosen, get some warning. > The > warning message is customized, e.g. telling in which future

[PATCH v2 1/2] Introduce (x86) CPU model deprecation API

2020-06-10 Thread Robert Hoo
Complement versioned CPU model framework with the ability of marking some versions deprecated. When that CPU model is chosen, get some warning. The warning message is customized, e.g. telling in which future QEMU version will it be obsoleted. The deprecation message will also appear by