Re: [PATCH v2 1/2] target/arm: Fix select for aa64_va_parameters_both

2020-02-15 Thread Richard Henderson
On 2/13/20 5:25 AM, Peter Maydell wrote: > On Thu, 13 Feb 2020 at 13:12, Peter Maydell wrote: >> >> On Tue, 11 Feb 2020 at 19:42, Richard Henderson >> wrote: >>> >>> Select should always be 0 for a regime with one range. >>> >>> Signed-off-by: Richard Henderson >> >> This change makes sense,

Re: [PATCH v2 1/2] target/arm: Fix select for aa64_va_parameters_both

2020-02-13 Thread Peter Maydell
On Thu, 13 Feb 2020 at 13:12, Peter Maydell wrote: > > On Tue, 11 Feb 2020 at 19:42, Richard Henderson > wrote: > > > > Select should always be 0 for a regime with one range. > > > > Signed-off-by: Richard Henderson > > This change makes sense, and matches what aa32_va_parameters() does, > but

Re: [PATCH v2 1/2] target/arm: Fix select for aa64_va_parameters_both

2020-02-13 Thread Peter Maydell
On Thu, 13 Feb 2020 at 13:12, Peter Maydell wrote: > > On Tue, 11 Feb 2020 at 19:42, Richard Henderson > wrote: > > > > Select should always be 0 for a regime with one range. > > > > Signed-off-by: Richard Henderson > > This change makes sense, and matches what aa32_va_parameters() does, > but

Re: [PATCH v2 1/2] target/arm: Fix select for aa64_va_parameters_both

2020-02-13 Thread Peter Maydell
On Tue, 11 Feb 2020 at 19:42, Richard Henderson wrote: > > Select should always be 0 for a regime with one range. > > Signed-off-by: Richard Henderson This change makes sense, and matches what aa32_va_parameters() does, but I think we need to update some of the callsites. (1) In

[PATCH v2 1/2] target/arm: Fix select for aa64_va_parameters_both

2020-02-11 Thread Richard Henderson
Select should always be 0 for a regime with one range. Signed-off-by: Richard Henderson --- target/arm/helper.c | 46 +++-- 1 file changed, 24 insertions(+), 22 deletions(-) diff --git a/target/arm/helper.c b/target/arm/helper.c index