Re: [PATCH v2 1/3] backup: don't acquire aio_context in backup_clean

2020-03-27 Thread Vladimir Sementsov-Ogievskiy
26.03.2020 18:56, Stefan Reiter wrote: All code-paths leading to backup_clean (via job_clean) have the job's context already acquired. The job's context is guaranteed to be the same as the one used by backup_top via backup_job_create. As we already discussed, this is not quite right. So, may

[PATCH v2 1/3] backup: don't acquire aio_context in backup_clean

2020-03-26 Thread Stefan Reiter
All code-paths leading to backup_clean (via job_clean) have the job's context already acquired. The job's context is guaranteed to be the same as the one used by backup_top via backup_job_create. Since the previous logic effectively acquired the lock twice, this broke cleanup of backups for disks