Re: [PATCH v2 1/3] hw/char/mchp_pfsoc_mmuart: Simplify MCHP_PFSOC_MMUART_REG definition

2021-09-28 Thread Alistair Francis
On Sat, Sep 25, 2021 at 11:34 PM Philippe Mathieu-Daudé wrote: > > The current MCHP_PFSOC_MMUART_REG_SIZE definition represent the > size occupied by all the registers. However all registers are > 32-bit wide, and the MemoryRegionOps handlers are restricted to > 32-bit: > > static const MemoryRe

Re: [PATCH v2 1/3] hw/char/mchp_pfsoc_mmuart: Simplify MCHP_PFSOC_MMUART_REG definition

2021-09-28 Thread Alistair Francis
On Sun, Sep 26, 2021 at 6:31 PM Bin Meng wrote: > > On Sat, Sep 25, 2021 at 9:34 PM Philippe Mathieu-Daudé > wrote: > > > > The current MCHP_PFSOC_MMUART_REG_SIZE definition represent the > > size occupied by all the registers. However all registers are > > 32-bit wide, and the MemoryRegionOps h

Re: [PATCH v2 1/3] hw/char/mchp_pfsoc_mmuart: Simplify MCHP_PFSOC_MMUART_REG definition

2021-09-28 Thread Alistair Francis
On Sat, Sep 25, 2021 at 11:34 PM Philippe Mathieu-Daudé wrote: > > The current MCHP_PFSOC_MMUART_REG_SIZE definition represent the > size occupied by all the registers. However all registers are > 32-bit wide, and the MemoryRegionOps handlers are restricted to > 32-bit: > > static const MemoryRe

Re: [PATCH v2 1/3] hw/char/mchp_pfsoc_mmuart: Simplify MCHP_PFSOC_MMUART_REG definition

2021-09-26 Thread Bin Meng
On Sun, Sep 26, 2021 at 4:31 PM Bin Meng wrote: > > On Sat, Sep 25, 2021 at 9:34 PM Philippe Mathieu-Daudé > wrote: > > > > The current MCHP_PFSOC_MMUART_REG_SIZE definition represent the > > size occupied by all the registers. However all registers are > > 32-bit wide, and the MemoryRegionOps h

Re: [PATCH v2 1/3] hw/char/mchp_pfsoc_mmuart: Simplify MCHP_PFSOC_MMUART_REG definition

2021-09-26 Thread Bin Meng
On Sat, Sep 25, 2021 at 9:34 PM Philippe Mathieu-Daudé wrote: > > The current MCHP_PFSOC_MMUART_REG_SIZE definition represent the > size occupied by all the registers. However all registers are > 32-bit wide, and the MemoryRegionOps handlers are restricted to > 32-bit: > > static const MemoryReg

[PATCH v2 1/3] hw/char/mchp_pfsoc_mmuart: Simplify MCHP_PFSOC_MMUART_REG definition

2021-09-25 Thread Philippe Mathieu-Daudé
The current MCHP_PFSOC_MMUART_REG_SIZE definition represent the size occupied by all the registers. However all registers are 32-bit wide, and the MemoryRegionOps handlers are restricted to 32-bit: static const MemoryRegionOps mchp_pfsoc_mmuart_ops = { .read = mchp_pfsoc_mmuart_read,