Re: [PATCH v2 1/7] target/ppc: fix ppc_store_sdr1 for user-only compilation

2021-05-18 Thread David Gibson
On Tue, May 18, 2021 at 12:05:09PM -0300, Bruno Larsen (billionai) wrote: > When the function was moved to cpu.c, it should have been wrapped with > #if !defined(CONFIG_USER_ONLY), otherwise linux-user builds don't work. I already corrected this in my tree, folding it into the original change to

[PATCH v2 1/7] target/ppc: fix ppc_store_sdr1 for user-only compilation

2021-05-18 Thread Bruno Larsen (billionai)
When the function was moved to cpu.c, it should have been wrapped with #if !defined(CONFIG_USER_ONLY), otherwise linux-user builds don't work. The cleanup suggested by Richard Henderson has also been applied, changing error_report(...) to qemu_log_mask(LOG_GUEST_ERROR, ...) in that function.