Re: [PATCH v2 10/20] vfio/pci: Make vfio_populate_device() return a bool

2024-05-22 Thread Cédric Le Goater
On 5/22/24 06:40, Zhenzhong Duan wrote: Since vfio_populate_device() takes an 'Error **' argument, best practices suggest to return a bool. See the qapi/error.h Rules section. By this chance, pass errp directly to vfio_populate_device() to avoid calling error_propagate(). Signed-off-by:

[PATCH v2 10/20] vfio/pci: Make vfio_populate_device() return a bool

2024-05-21 Thread Zhenzhong Duan
Since vfio_populate_device() takes an 'Error **' argument, best practices suggest to return a bool. See the qapi/error.h Rules section. By this chance, pass errp directly to vfio_populate_device() to avoid calling error_propagate(). Signed-off-by: Zhenzhong Duan --- hw/vfio/pci.c | 21