Re: [PATCH v2 13/36] tcg: Use tcg_constant_{i32,i64} with tcg int expanders

2020-04-24 Thread Alex Bennée
Richard Henderson writes: > On 4/22/20 1:04 PM, Alex Bennée wrote: >> >> Richard Henderson writes: >> >>> Signed-off-by: Richard Henderson >> >> We have a regression. Setting up a build dir with: >> >> ../../configure --disable-tools --disable-docs >>

Re: [PATCH v2 13/36] tcg: Use tcg_constant_{i32,i64} with tcg int expanders

2020-04-23 Thread Richard Henderson
On 4/22/20 1:04 PM, Alex Bennée wrote: > > Richard Henderson writes: > >> Signed-off-by: Richard Henderson > > We have a regression. Setting up a build dir with: > > ../../configure --disable-tools --disable-docs > --target-list=sparc-softmmu,sparc64-softmmu > make -j30 && make

Re: [PATCH v2 13/36] tcg: Use tcg_constant_{i32,i64} with tcg int expanders

2020-04-22 Thread Alex Bennée
Richard Henderson writes: > Signed-off-by: Richard Henderson We have a regression. Setting up a build dir with: ../../configure --disable-tools --disable-docs --target-list=sparc-softmmu,sparc64-softmmu make -j30 && make check-acceptance And then running a bisect between HEAD and

Re: [PATCH v2 13/36] tcg: Use tcg_constant_{i32,i64} with tcg int expanders

2020-04-22 Thread Alex Bennée
Richard Henderson writes: > On 4/22/20 9:18 AM, Alex Bennée wrote: >>> void tcg_gen_brcondi_i64(TCGCond cond, TCGv_i64 arg1, int64_t arg2, >>> TCGLabel *l) >>> { >>> -if (cond == TCG_COND_ALWAYS) { >>> +if (TCG_TARGET_REG_BITS == 64) { >>> +tcg_gen_brcond_i64(cond, arg1,

Re: [PATCH v2 13/36] tcg: Use tcg_constant_{i32,i64} with tcg int expanders

2020-04-22 Thread Richard Henderson
On 4/22/20 9:18 AM, Alex Bennée wrote: >> void tcg_gen_brcondi_i64(TCGCond cond, TCGv_i64 arg1, int64_t arg2, >> TCGLabel *l) >> { >> -if (cond == TCG_COND_ALWAYS) { >> +if (TCG_TARGET_REG_BITS == 64) { >> +tcg_gen_brcond_i64(cond, arg1, tcg_constant_i64(arg2), l); >> +}

Re: [PATCH v2 13/36] tcg: Use tcg_constant_{i32,i64} with tcg int expanders

2020-04-22 Thread Alex Bennée
Richard Henderson writes: > Signed-off-by: Richard Henderson > --- > include/tcg/tcg-op.h | 13 +-- > tcg/tcg-op.c | 216 --- > 2 files changed, 100 insertions(+), 129 deletions(-) > > diff --git a/include/tcg/tcg-op.h b/include/tcg/tcg-op.h >

[PATCH v2 13/36] tcg: Use tcg_constant_{i32, i64} with tcg int expanders

2020-04-21 Thread Richard Henderson
Signed-off-by: Richard Henderson --- include/tcg/tcg-op.h | 13 +-- tcg/tcg-op.c | 216 --- 2 files changed, 100 insertions(+), 129 deletions(-) diff --git a/include/tcg/tcg-op.h b/include/tcg/tcg-op.h index 230db6e022..11ed9192f7 100644 ---