Re: [PATCH v2 17/23] target/i386: Create gen_jmp_rel

2022-10-01 Thread Paolo Bonzini
On Sat, Oct 1, 2022 at 2:53 AM Richard Henderson wrote: > I believe it really should be s->dflag, which makes all users of the function > pass dflag > (the manual consistently talks about "operand size"). At which point this > parameter goes > away and gen_jmp_rel grabs the operand size from

Re: [PATCH v2 17/23] target/i386: Create gen_jmp_rel

2022-09-30 Thread Richard Henderson
On 9/21/22 06:06, Paolo Bonzini wrote: On Tue, Sep 6, 2022 at 12:09 PM Richard Henderson wrote: Create a common helper for pc-relative branches. The jmp jb insn was missing a mask for CODE32. Signed-off-by: Richard Henderson (Oops, my remark the previous patch should still have pointed to

Re: [PATCH v2 17/23] target/i386: Create gen_jmp_rel

2022-09-21 Thread Paolo Bonzini
On Tue, Sep 6, 2022 at 12:09 PM Richard Henderson wrote: > > Create a common helper for pc-relative branches. > The jmp jb insn was missing a mask for CODE32. > > Signed-off-by: Richard Henderson (Oops, my remark the previous patch should still have pointed to gen_jmp_tb). In

[PATCH v2 17/23] target/i386: Create gen_jmp_rel

2022-09-06 Thread Richard Henderson
Create a common helper for pc-relative branches. The jmp jb insn was missing a mask for CODE32. Signed-off-by: Richard Henderson --- target/i386/tcg/translate.c | 57 ++--- 1 file changed, 27 insertions(+), 30 deletions(-) diff --git