Re: [PATCH v2 19/21] gdbstub: move register helpers into standalone include

2023-01-06 Thread Richard Henderson
On 1/5/23 08:43, Alex Bennée wrote: These inline helpers are all used by target specific code so move them out of the general header so we don't needlessly pollute the rest of the API with target specific stuff. Note we have to include cpu.h in semihosting as it was relying on a side effect

Re: [PATCH v2 19/21] gdbstub: move register helpers into standalone include

2023-01-05 Thread Max Filippov
On Thu, Jan 5, 2023 at 8:51 AM Alex Bennée wrote: > > These inline helpers are all used by target specific code so move them > out of the general header so we don't needlessly pollute the rest of > the API with target specific stuff. > > Note we have to include cpu.h in semihosting as it was

Re: [PATCH v2 19/21] gdbstub: move register helpers into standalone include

2023-01-05 Thread Philippe Mathieu-Daudé
On 5/1/23 17:43, Alex Bennée wrote: These inline helpers are all used by target specific code so move them out of the general header so we don't needlessly pollute the rest of the API with target specific stuff. Note we have to include cpu.h in semihosting as it was relying on a side effect

RE: [PATCH v2 19/21] gdbstub: move register helpers into standalone include

2023-01-05 Thread Taylor Simpson
ang > ; Philippe Mathieu-Daudé ; > Bin Meng ; Mahmoud Mandour > ; David Gibson ; > Yoshinori Sato ; Xiaojuan Yang > ; qemu-...@nongnu.org > Subject: [PATCH v2 19/21] gdbstub: move register helpers into standalone > include > > These inline helpers are all used by target

[PATCH v2 19/21] gdbstub: move register helpers into standalone include

2023-01-05 Thread Alex Bennée
These inline helpers are all used by target specific code so move them out of the general header so we don't needlessly pollute the rest of the API with target specific stuff. Note we have to include cpu.h in semihosting as it was relying on a side effect before. Signed-off-by: Alex Bennée ---