Re: [PATCH v2 2/2] hw/ide: add ich6 ide controller device emulation

2022-02-21 Thread Liav Albani
On 2/21/22 13:33, Gerd Hoffmann wrote: Hi, ICH6 and ICH7 IDE controllers are quite the same as far as I know. I could change it, but then one could argue that the name ich6-ide seems like "ich9-ide", so not sure if we can really go on this path. I think we don't actually have ich9-ide,

Re: [PATCH v2 2/2] hw/ide: add ich6 ide controller device emulation

2022-02-21 Thread Gerd Hoffmann
Hi, > > ICH6 and ICH7 IDE controllers are quite the same as far as I know. I > > could change it, but then one could argue that the name ich6-ide seems > > like "ich9-ide", so not sure if we can really go on this path. > > I think we don't actually have ich9-ide, we only have piix3, piix4 and

Re: [PATCH v2 2/2] hw/ide: add ich6 ide controller device emulation

2022-02-19 Thread BALATON Zoltan
On Sat, 19 Feb 2022, Liav Albani wrote: On 2/19/22 02:50, BALATON Zoltan wrote: +/* + * QEMU IDE Emulation: PCI ICH6/ICH7 IDE support. This is a small thing, but if these two are the same maybe keeping this comment but using the ich7 name everywhere else would make it less likely to get it

Re: [PATCH v2 2/2] hw/ide: add ich6 ide controller device emulation

2022-02-18 Thread Liav Albani
On 2/19/22 02:50, BALATON Zoltan wrote: +/* + * QEMU IDE Emulation: PCI ICH6/ICH7 IDE support. This is a small thing, but if these two are the same maybe keeping this comment but using the ich7 name everywhere else would make it less likely to get it confused with ich9. I mean ich6 and

Re: [PATCH v2 2/2] hw/ide: add ich6 ide controller device emulation

2022-02-18 Thread BALATON Zoltan
On Fri, 18 Feb 2022, Liav Albani wrote: This type of IDE controller has support for relocating the IO ports and doesn't use IRQ 14 and 15 but one allocated PCI IRQ for the controller. There's no x86 chipset in QEMU that will try to attach this device by default. It is considered a legacy-free

[PATCH v2 2/2] hw/ide: add ich6 ide controller device emulation

2022-02-18 Thread Liav Albani
This type of IDE controller has support for relocating the IO ports and doesn't use IRQ 14 and 15 but one allocated PCI IRQ for the controller. There's no x86 chipset in QEMU that will try to attach this device by default. It is considered a legacy-free device in the aspect of PCI bus resource