On Mon, Mar 16, 2020 at 07:20:02PM +, Peter Maydell wrote:
> On Mon, 16 Mar 2020 at 18:40, Eduardo Habkost wrote:
> >
> > On Mon, Mar 16, 2020 at 06:08:54PM +, Peter Maydell wrote:
> > > The usual approach is that if you don't have the Linux-specific
> > > feature available you quietly
On Mon, 16 Mar 2020 at 18:40, Eduardo Habkost wrote:
>
> On Mon, Mar 16, 2020 at 06:08:54PM +, Peter Maydell wrote:
> > The usual approach is that if you don't have the Linux-specific
> > feature available you quietly fall back to whatever the sensible
> > behaviour is for when the feature
On Mon, Mar 16, 2020 at 02:40:46PM -0400, Eduardo Habkost wrote:
> On Mon, Mar 16, 2020 at 06:08:54PM +, Peter Maydell wrote:
> > On Mon, 16 Mar 2020 at 17:51, Eduardo Habkost wrote:
> > > Yes, but both MAP_SYNC and MAP_SHARED_VALIDATE aren't available
> > > if the host is not Linux.
> > >
>
On Sun, Mar 15, 2020 at 05:15:46PM -0400, Michael S. Tsirkin wrote:
> On Sun, Mar 15, 2020 at 11:45:59AM -0400, Eduardo Habkost wrote:
> > On Wed, Mar 11, 2020 at 07:23:42PM -0400, Eduardo Habkost wrote:
> > > The CONFIG_LINUX check at the top of mmap-alloc.c never worked
> > > because it was done
On Mon, 16 Mar 2020 at 17:51, Eduardo Habkost wrote:
> Yes, but both MAP_SYNC and MAP_SHARED_VALIDATE aren't available
> if the host is not Linux.
>
> Defining MAP_SYNC to 0 on MIPS would restore the existing
> behavior, so it seems like a reasonable step to fix the build
> failure. But not even
On Mon, Mar 16, 2020 at 06:08:54PM +, Peter Maydell wrote:
> On Mon, 16 Mar 2020 at 17:51, Eduardo Habkost wrote:
> > Yes, but both MAP_SYNC and MAP_SHARED_VALIDATE aren't available
> > if the host is not Linux.
> >
> > Defining MAP_SYNC to 0 on MIPS would restore the existing
> > behavior,
On Sun, Mar 15, 2020 at 11:45:59AM -0400, Eduardo Habkost wrote:
> On Wed, Mar 11, 2020 at 07:23:42PM -0400, Eduardo Habkost wrote:
> > The CONFIG_LINUX check at the top of mmap-alloc.c never worked
> > because it was done before including osdep.h.
> >
> > This means MAP_SYNC and
On Wed, Mar 11, 2020 at 07:23:42PM -0400, Eduardo Habkost wrote:
> The CONFIG_LINUX check at the top of mmap-alloc.c never worked
> because it was done before including osdep.h.
>
> This means MAP_SYNC and MAP_SHARED_VALIDATE would always be set
> to 0 at the beginning of the file. Luckily, this
On Wed, Mar 11, 2020 at 07:23:42PM -0400, Eduardo Habkost wrote:
> The CONFIG_LINUX check at the top of mmap-alloc.c never worked
> because it was done before including osdep.h.
>
> This means MAP_SYNC and MAP_SHARED_VALIDATE would always be set
> to 0 at the beginning of the file. Luckily, this
The CONFIG_LINUX check at the top of mmap-alloc.c never worked
because it was done before including osdep.h.
This means MAP_SYNC and MAP_SHARED_VALIDATE would always be set
to 0 at the beginning of the file. Luckily, this didn't break
when using recent glibc versions (2.28+), because those
10 matches
Mail list logo