Re: [PATCH v2 2/2] net: Drop the NetLegacy structure, always use Netdev instead

2020-05-13 Thread Thomas Huth
On 12/05/2020 17.51, Eric Blake wrote: > On 5/12/20 10:13 AM, Thomas Huth wrote: > +++ b/qapi/net.json @@ -453,7 +453,7 @@    #    'l2tpv3' - since 2.1    ##    { 'union': 'Netdev', -  'base': { 'id': 'str', 'type': 'NetClientDriver' }, +  'base': { '*id':

Re: [PATCH v2 2/2] net: Drop the NetLegacy structure, always use Netdev instead

2020-05-12 Thread Eric Blake
On 5/12/20 10:13 AM, Thomas Huth wrote: +++ b/qapi/net.json @@ -453,7 +453,7 @@   #    'l2tpv3' - since 2.1   ##   { 'union': 'Netdev', -  'base': { 'id': 'str', 'type': 'NetClientDriver' }, +  'base': { '*id': 'str', 'type': 'NetClientDriver' }, I don't think we need to make 'id'

Re: [PATCH v2 2/2] net: Drop the NetLegacy structure, always use Netdev instead

2020-05-12 Thread Thomas Huth
On 12/05/2020 16.32, Eric Blake wrote: > On 5/12/20 7:31 AM, Thomas Huth wrote: >> Now that the "name" parameter is gone, there is hardly any difference >> between NetLegacy and Netdev anymore. Drop NetLegacy and always use >> Netdev to simplify the code quite a bit. >> >> Signed-off-by: Thomas

Re: [PATCH v2 2/2] net: Drop the NetLegacy structure, always use Netdev instead

2020-05-12 Thread Eric Blake
On 5/12/20 7:31 AM, Thomas Huth wrote: Now that the "name" parameter is gone, there is hardly any difference between NetLegacy and Netdev anymore. Drop NetLegacy and always use Netdev to simplify the code quite a bit. Signed-off-by: Thomas Huth --- +++ b/net/net.c @@ -967,13 +967,14 @@

[PATCH v2 2/2] net: Drop the NetLegacy structure, always use Netdev instead

2020-05-12 Thread Thomas Huth
Now that the "name" parameter is gone, there is hardly any difference between NetLegacy and Netdev anymore. Drop NetLegacy and always use Netdev to simplify the code quite a bit. Signed-off-by: Thomas Huth --- net/net.c | 74 --- qapi/net.json