Re: [PATCH v2 2/4] smbus: Fix spd_data_generate() error API violation

2020-06-30 Thread BALATON Zoltan
On Tue, 30 Jun 2020, Philippe Mathieu-Daudé wrote: On 6/29/20 11:31 PM, BALATON Zoltan wrote: Besides the above here's another use case of the fix ups that I wanted to keep: https://patchew.org/QEMU/cover.1592315226.git.bala...@eik.bme.hu/b5f4598529a77f15f554c593e9be2d0ff9e5fab3.1592315226.git.

Re: [PATCH v2 2/4] smbus: Fix spd_data_generate() error API violation

2020-06-29 Thread Philippe Mathieu-Daudé
On 6/29/20 11:31 PM, BALATON Zoltan wrote: > On Mon, 29 Jun 2020, Philippe Mathieu-Daudé wrote: >> On 6/27/20 9:17 AM, Markus Armbruster wrote: >>> BALATON Zoltan writes: On Wed, 22 Apr 2020, BALATON Zoltan wrote: > On Wed, 22 Apr 2020, Philippe Mathieu-Daudé wrote: >> On 4/

Re: [PATCH v2 2/4] smbus: Fix spd_data_generate() error API violation

2020-06-29 Thread BALATON Zoltan
On Mon, 29 Jun 2020, Markus Armbruster wrote: BALATON Zoltan writes: On Sat, 27 Jun 2020, Markus Armbruster wrote: Quick reply without having thought through the issues at all: I'm not Does that mean you'll reply later with more detail or this is all you had to say about this? (Just to know

Re: [PATCH v2 2/4] smbus: Fix spd_data_generate() error API violation

2020-06-29 Thread BALATON Zoltan
On Mon, 29 Jun 2020, Philippe Mathieu-Daudé wrote: On 6/27/20 9:17 AM, Markus Armbruster wrote: BALATON Zoltan writes: On Wed, 22 Apr 2020, BALATON Zoltan wrote: On Wed, 22 Apr 2020, Philippe Mathieu-Daudé wrote: On 4/22/20 4:27 PM, BALATON Zoltan wrote: On Wed, 22 Apr 2020, Markus Armbrus

Re: [PATCH v2 2/4] smbus: Fix spd_data_generate() error API violation

2020-06-29 Thread Philippe Mathieu-Daudé
On 6/27/20 9:17 AM, Markus Armbruster wrote: > BALATON Zoltan writes: > >> On Wed, 22 Apr 2020, BALATON Zoltan wrote: >>> On Wed, 22 Apr 2020, Philippe Mathieu-Daudé wrote: On 4/22/20 4:27 PM, BALATON Zoltan wrote: > On Wed, 22 Apr 2020, Markus Armbruster wrote: >> The Error ** argu

Re: [PATCH v2 2/4] smbus: Fix spd_data_generate() error API violation

2020-06-29 Thread Markus Armbruster
BALATON Zoltan writes: > On Sat, 27 Jun 2020, Markus Armbruster wrote: >> Quick reply without having thought through the issues at all: I'm not > > Does that mean you'll reply later with more detail or this is all you > had to say about this? (Just to know if I should wait for another > reply.)

Re: [PATCH v2 2/4] smbus: Fix spd_data_generate() error API violation

2020-06-27 Thread BALATON Zoltan
On Sat, 27 Jun 2020, Markus Armbruster wrote: BALATON Zoltan writes: On Wed, 22 Apr 2020, BALATON Zoltan wrote: On Wed, 22 Apr 2020, Philippe Mathieu-Daudé wrote: On 4/22/20 4:27 PM, BALATON Zoltan wrote: On Wed, 22 Apr 2020, Markus Armbruster wrote: The Error ** argument must be NULL, &er

Re: [PATCH v2 2/4] smbus: Fix spd_data_generate() error API violation

2020-06-27 Thread Markus Armbruster
BALATON Zoltan writes: > On Wed, 22 Apr 2020, BALATON Zoltan wrote: >> On Wed, 22 Apr 2020, Philippe Mathieu-Daudé wrote: >>> On 4/22/20 4:27 PM, BALATON Zoltan wrote: On Wed, 22 Apr 2020, Markus Armbruster wrote: > The Error ** argument must be NULL, &error_abort, &error_fatal, or a >>

Re: [PATCH v2 2/4] smbus: Fix spd_data_generate() error API violation

2020-06-26 Thread BALATON Zoltan
On Wed, 22 Apr 2020, BALATON Zoltan wrote: On Wed, 22 Apr 2020, Philippe Mathieu-Daudé wrote: On 4/22/20 4:27 PM, BALATON Zoltan wrote: On Wed, 22 Apr 2020, Markus Armbruster wrote: The Error ** argument must be NULL, &error_abort, &error_fatal, or a pointer to a variable containing NULL.  Pas

Re: [PATCH v2 2/4] smbus: Fix spd_data_generate() error API violation

2020-04-22 Thread BALATON Zoltan
On Wed, 22 Apr 2020, Philippe Mathieu-Daudé wrote: On 4/22/20 4:27 PM, BALATON Zoltan wrote: On Wed, 22 Apr 2020, Markus Armbruster wrote: The Error ** argument must be NULL, &error_abort, &error_fatal, or a pointer to a variable containing NULL.  Passing an argument of the latter kind twice wi

Re: [PATCH v2 2/4] smbus: Fix spd_data_generate() error API violation

2020-04-22 Thread Philippe Mathieu-Daudé
On 4/22/20 4:27 PM, BALATON Zoltan wrote: On Wed, 22 Apr 2020, Markus Armbruster wrote: The Error ** argument must be NULL, &error_abort, &error_fatal, or a pointer to a variable containing NULL.  Passing an argument of the latter kind twice without clearing it in between is wrong: if the first

Re: [PATCH v2 2/4] smbus: Fix spd_data_generate() error API violation

2020-04-22 Thread BALATON Zoltan
On Wed, 22 Apr 2020, Markus Armbruster wrote: The Error ** argument must be NULL, &error_abort, &error_fatal, or a pointer to a variable containing NULL. Passing an argument of the latter kind twice without clearing it in between is wrong: if the first call sets an error, it no longer points to

[PATCH v2 2/4] smbus: Fix spd_data_generate() error API violation

2020-04-22 Thread Markus Armbruster
The Error ** argument must be NULL, &error_abort, &error_fatal, or a pointer to a variable containing NULL. Passing an argument of the latter kind twice without clearing it in between is wrong: if the first call sets an error, it no longer points to NULL for the second call. spd_data_generate() c