Re: [PATCH v2 2/7] virtiofds: Changed allocations of iovec to GLib's functions

2021-04-27 Thread Dr. David Alan Gilbert
* Mahmoud Mandour (ma.mando...@gmail.com) wrote: > On Tue, Apr 27, 2021 at 1:33 PM Dr. David Alan Gilbert > wrote: > > > * Mahmoud Mandour (ma.mando...@gmail.com) wrote: > > > On Tue, Apr 27, 2021 at 1:01 PM Dr. David Alan Gilbert < > > dgilb...@redhat.com> > > > wrote: > > > > > > > * Mahmoud Ma

Re: [PATCH v2 2/7] virtiofds: Changed allocations of iovec to GLib's functions

2021-04-27 Thread Mahmoud Mandour
On Tue, Apr 27, 2021 at 1:33 PM Dr. David Alan Gilbert wrote: > * Mahmoud Mandour (ma.mando...@gmail.com) wrote: > > On Tue, Apr 27, 2021 at 1:01 PM Dr. David Alan Gilbert < > dgilb...@redhat.com> > > wrote: > > > > > * Mahmoud Mandour (ma.mando...@gmail.com) wrote: > > > > On Tue, Apr 27, 2021 a

Re: [PATCH v2 2/7] virtiofds: Changed allocations of iovec to GLib's functions

2021-04-27 Thread Dr. David Alan Gilbert
* Mahmoud Mandour (ma.mando...@gmail.com) wrote: > On Tue, Apr 27, 2021 at 1:01 PM Dr. David Alan Gilbert > wrote: > > > * Mahmoud Mandour (ma.mando...@gmail.com) wrote: > > > On Tue, Apr 27, 2021 at 12:25 PM Dr. David Alan Gilbert < > > dgilb...@redhat.com> > > > wrote: > > > > > > > * Mahmoud M

Re: [PATCH v2 2/7] virtiofds: Changed allocations of iovec to GLib's functions

2021-04-27 Thread Mahmoud Mandour
On Tue, Apr 27, 2021 at 1:01 PM Dr. David Alan Gilbert wrote: > * Mahmoud Mandour (ma.mando...@gmail.com) wrote: > > On Tue, Apr 27, 2021 at 12:25 PM Dr. David Alan Gilbert < > dgilb...@redhat.com> > > wrote: > > > > > * Mahmoud Mandour (ma.mando...@gmail.com) wrote: > > > > Replaced the calls to

Re: [PATCH v2 2/7] virtiofds: Changed allocations of iovec to GLib's functions

2021-04-27 Thread Dr. David Alan Gilbert
* Mahmoud Mandour (ma.mando...@gmail.com) wrote: > On Tue, Apr 27, 2021 at 12:25 PM Dr. David Alan Gilbert > wrote: > > > * Mahmoud Mandour (ma.mando...@gmail.com) wrote: > > > Replaced the calls to malloc()/calloc() and their respective > > > calls to free() of iovec structs with GLib's allocati

Re: [PATCH v2 2/7] virtiofds: Changed allocations of iovec to GLib's functions

2021-04-27 Thread Daniel P . Berrangé
On Tue, Apr 27, 2021 at 11:24:42AM +0100, Dr. David Alan Gilbert wrote: > * Mahmoud Mandour (ma.mando...@gmail.com) wrote: > > Replaced the calls to malloc()/calloc() and their respective > > calls to free() of iovec structs with GLib's allocation and > > deallocation functions. > > > > Also, in o

Re: [PATCH v2 2/7] virtiofds: Changed allocations of iovec to GLib's functions

2021-04-27 Thread Mahmoud Mandour
On Tue, Apr 27, 2021 at 12:25 PM Dr. David Alan Gilbert wrote: > * Mahmoud Mandour (ma.mando...@gmail.com) wrote: > > Replaced the calls to malloc()/calloc() and their respective > > calls to free() of iovec structs with GLib's allocation and > > deallocation functions. > > > > Also, in one insta

Re: [PATCH v2 2/7] virtiofds: Changed allocations of iovec to GLib's functions

2021-04-27 Thread Dr. David Alan Gilbert
* Mahmoud Mandour (ma.mando...@gmail.com) wrote: > Replaced the calls to malloc()/calloc() and their respective > calls to free() of iovec structs with GLib's allocation and > deallocation functions. > > Also, in one instance, used g_new0() instead of a calloc() call plus > a null-checking asserti

[PATCH v2 2/7] virtiofds: Changed allocations of iovec to GLib's functions

2021-04-20 Thread Mahmoud Mandour
Replaced the calls to malloc()/calloc() and their respective calls to free() of iovec structs with GLib's allocation and deallocation functions. Also, in one instance, used g_new0() instead of a calloc() call plus a null-checking assertion. iovec structs were created locally and freed as the func