Re: [PATCH v2 3/3] pci: ROM preallocation for incoming migration

2023-05-10 Thread Vladimir Sementsov-Ogievskiy
On 09.05.23 18:54, Michael S. Tsirkin wrote: On Wed, May 03, 2023 at 02:39:15PM +0300, Vladimir Sementsov-Ogievskiy wrote: On 03.05.23 13:05, Michael S. Tsirkin wrote: On Wed, May 03, 2023 at 12:50:09PM +0300, Vladimir Sementsov-Ogievskiy wrote: On 03.05.23 12:20, David Hildenbrand wrote: On

Re: [PATCH v2 3/3] pci: ROM preallocation for incoming migration

2023-05-09 Thread David Hildenbrand
On 09.05.23 17:54, Michael S. Tsirkin wrote: On Wed, May 03, 2023 at 02:39:15PM +0300, Vladimir Sementsov-Ogievskiy wrote: On 03.05.23 13:05, Michael S. Tsirkin wrote: On Wed, May 03, 2023 at 12:50:09PM +0300, Vladimir Sementsov-Ogievskiy wrote: On 03.05.23 12:20, David Hildenbrand wrote: On

Re: [PATCH v2 3/3] pci: ROM preallocation for incoming migration

2023-05-09 Thread Michael S. Tsirkin
On Wed, May 03, 2023 at 02:39:15PM +0300, Vladimir Sementsov-Ogievskiy wrote: > On 03.05.23 13:05, Michael S. Tsirkin wrote: > > On Wed, May 03, 2023 at 12:50:09PM +0300, Vladimir Sementsov-Ogievskiy > > wrote: > > > On 03.05.23 12:20, David Hildenbrand wrote: > > > > On 25.04.23 18:14, Vladimir S

Re: [PATCH v2 3/3] pci: ROM preallocation for incoming migration

2023-05-09 Thread Juan Quintela
"Michael S. Tsirkin" wrote: > On Tue, May 02, 2023 at 12:11:38PM +0200, Juan Quintela wrote: >> "Michael S. Tsirkin" wrote: >> >> >> > CC pbonzini,dgilbert,quintela,armbru : guys, is poking at >> >> > runstate_check like >> >> > this the right way to figure out we are not going to use the >> >>

Re: [PATCH v2 3/3] pci: ROM preallocation for incoming migration

2023-05-03 Thread Vladimir Sementsov-Ogievskiy
On 03.05.23 13:05, Michael S. Tsirkin wrote: On Wed, May 03, 2023 at 12:50:09PM +0300, Vladimir Sementsov-Ogievskiy wrote: On 03.05.23 12:20, David Hildenbrand wrote: On 25.04.23 18:14, Vladimir Sementsov-Ogievskiy wrote: On incoming migration we have the following sequence to load option ROM:

Re: [PATCH v2 3/3] pci: ROM preallocation for incoming migration

2023-05-03 Thread Michael S. Tsirkin
On Wed, May 03, 2023 at 12:50:09PM +0300, Vladimir Sementsov-Ogievskiy wrote: > On 03.05.23 12:20, David Hildenbrand wrote: > > On 25.04.23 18:14, Vladimir Sementsov-Ogievskiy wrote: > > > On incoming migration we have the following sequence to load option > > > ROM: > > > > > > 1. On device reali

Re: [PATCH v2 3/3] pci: ROM preallocation for incoming migration

2023-05-03 Thread Vladimir Sementsov-Ogievskiy
On 03.05.23 12:20, David Hildenbrand wrote: On 25.04.23 18:14, Vladimir Sementsov-Ogievskiy wrote: On incoming migration we have the following sequence to load option ROM: 1. On device realize we do normal load ROM from the file 2. Than, on incoming migration we rewrite ROM from the incoming R

Re: [PATCH v2 3/3] pci: ROM preallocation for incoming migration

2023-05-03 Thread David Hildenbrand
On 25.04.23 18:14, Vladimir Sementsov-Ogievskiy wrote: On incoming migration we have the following sequence to load option ROM: 1. On device realize we do normal load ROM from the file 2. Than, on incoming migration we rewrite ROM from the incoming RAM block. If sizes mismatch we fail. Thi

Re: [PATCH v2 3/3] pci: ROM preallocation for incoming migration

2023-05-02 Thread Michael S. Tsirkin
On Tue, May 02, 2023 at 12:11:38PM +0200, Juan Quintela wrote: > "Michael S. Tsirkin" wrote: > > >> > CC pbonzini,dgilbert,quintela,armbru : guys, is poking at runstate_check > >> > like > >> > this the right way to figure out we are not going to use the > >> > device locally before incoming mig

Re: [PATCH v2 3/3] pci: ROM preallocation for incoming migration

2023-05-02 Thread Vladimir Sementsov-Ogievskiy
On 02.05.23 13:11, Juan Quintela wrote: "Michael S. Tsirkin" wrote: CC pbonzini,dgilbert,quintela,armbru : guys, is poking at runstate_check like this the right way to figure out we are not going to use the device locally before incoming migration will overwrite ROM contents? RUN_STATE_INMIG

Re: [PATCH v2 3/3] pci: ROM preallocation for incoming migration

2023-05-02 Thread Juan Quintela
"Michael S. Tsirkin" wrote: >> > CC pbonzini,dgilbert,quintela,armbru : guys, is poking at runstate_check >> > like >> > this the right way to figure out we are not going to use the >> > device locally before incoming migration will overwrite ROM contents? >> >> RUN_STATE_INMIGRATE is set in th

Re: [PATCH v2 3/3] pci: ROM preallocation for incoming migration

2023-05-02 Thread Vladimir Sementsov-Ogievskiy
On 02.05.23 12:48, Michael S. Tsirkin wrote: On Wed, Apr 26, 2023 at 11:00:46PM +0300, Vladimir Sementsov-Ogievskiy wrote: On 26.04.23 07:43, Michael S. Tsirkin wrote: On Tue, Apr 25, 2023 at 07:14:34PM +0300, Vladimir Sementsov-Ogievskiy wrote: On incoming migration we have the following sequ

Re: [PATCH v2 3/3] pci: ROM preallocation for incoming migration

2023-05-02 Thread Michael S. Tsirkin
On Wed, Apr 26, 2023 at 11:00:46PM +0300, Vladimir Sementsov-Ogievskiy wrote: > On 26.04.23 07:43, Michael S. Tsirkin wrote: > > On Tue, Apr 25, 2023 at 07:14:34PM +0300, Vladimir Sementsov-Ogievskiy > > wrote: > > > On incoming migration we have the following sequence to load option > > > ROM: >

Re: [PATCH v2 3/3] pci: ROM preallocation for incoming migration

2023-04-28 Thread Vladimir Sementsov-Ogievskiy
On 28.04.23 11:30, Juan Quintela wrote: "Michael S. Tsirkin" wrote: On Tue, Apr 25, 2023 at 07:14:34PM +0300, Vladimir Sementsov-Ogievskiy wrote: On incoming migration we have the following sequence to load option ROM: 1. On device realize we do normal load ROM from the file 2. Than, on inco

Re: [PATCH v2 3/3] pci: ROM preallocation for incoming migration

2023-04-28 Thread Juan Quintela
"Michael S. Tsirkin" wrote: > On Tue, Apr 25, 2023 at 07:14:34PM +0300, Vladimir Sementsov-Ogievskiy wrote: >> On incoming migration we have the following sequence to load option >> ROM: >> >> 1. On device realize we do normal load ROM from the file >> >> 2. Than, on incoming migration we rewrit

Re: [PATCH v2 3/3] pci: ROM preallocation for incoming migration

2023-04-26 Thread Vladimir Sementsov-Ogievskiy
On 26.04.23 07:43, Michael S. Tsirkin wrote: On Tue, Apr 25, 2023 at 07:14:34PM +0300, Vladimir Sementsov-Ogievskiy wrote: On incoming migration we have the following sequence to load option ROM: 1. On device realize we do normal load ROM from the file 2. Than, on incoming migration we rewrite

Re: [PATCH v2 3/3] pci: ROM preallocation for incoming migration

2023-04-25 Thread Michael S. Tsirkin
On Tue, Apr 25, 2023 at 07:14:34PM +0300, Vladimir Sementsov-Ogievskiy wrote: > On incoming migration we have the following sequence to load option > ROM: > > 1. On device realize we do normal load ROM from the file > > 2. Than, on incoming migration we rewrite ROM from the incoming RAM >bloc

[PATCH v2 3/3] pci: ROM preallocation for incoming migration

2023-04-25 Thread Vladimir Sementsov-Ogievskiy
On incoming migration we have the following sequence to load option ROM: 1. On device realize we do normal load ROM from the file 2. Than, on incoming migration we rewrite ROM from the incoming RAM block. If sizes mismatch we fail. This is not ideal when we migrate to updated distribution: we