Re: [PATCH v2 3/3] s390x/pci: drive ISM reset from subsystem reset

2024-01-23 Thread Halil Pasic
On Mon, 22 Jan 2024 10:06:38 -0500 Matthew Rosato wrote: > On 1/19/24 4:07 PM, Halil Pasic wrote: > > On Thu, 18 Jan 2024 13:51:51 -0500 > > Matthew Rosato wrote: > > > >> diff --git a/hw/s390x/s390-virtio-ccw.c b/hw/s390x/s390-virtio-ccw.c > >> index eaf61d3640..c99682b07d 100644 > >> --- a/

Re: [PATCH v2 3/3] s390x/pci: drive ISM reset from subsystem reset

2024-01-22 Thread Matthew Rosato
On 1/19/24 4:07 PM, Halil Pasic wrote: > On Thu, 18 Jan 2024 13:51:51 -0500 > Matthew Rosato wrote: > >> diff --git a/hw/s390x/s390-virtio-ccw.c b/hw/s390x/s390-virtio-ccw.c >> index eaf61d3640..c99682b07d 100644 >> --- a/hw/s390x/s390-virtio-ccw.c >> +++ b/hw/s390x/s390-virtio-ccw.c >> @@ -118,6

Re: [PATCH v2 3/3] s390x/pci: drive ISM reset from subsystem reset

2024-01-19 Thread Halil Pasic
On Thu, 18 Jan 2024 13:51:51 -0500 Matthew Rosato wrote: > diff --git a/hw/s390x/s390-virtio-ccw.c b/hw/s390x/s390-virtio-ccw.c > index eaf61d3640..c99682b07d 100644 > --- a/hw/s390x/s390-virtio-ccw.c > +++ b/hw/s390x/s390-virtio-ccw.c > @@ -118,6 +118,14 @@ static void subsystem_reset(void) >

Re: [PATCH v2 3/3] s390x/pci: drive ISM reset from subsystem reset

2024-01-18 Thread Eric Farman
On Thu, 2024-01-18 at 13:51 -0500, Matthew Rosato wrote: > ISM devices are sensitive to manipulation of the IOMMU, so the ISM > device > needs to be reset before the vfio-pci device is reset (triggering a > full > UNMAP).  In order to ensure this occurs, trigger ISM device resets > from > subsystem

[PATCH v2 3/3] s390x/pci: drive ISM reset from subsystem reset

2024-01-18 Thread Matthew Rosato
ISM devices are sensitive to manipulation of the IOMMU, so the ISM device needs to be reset before the vfio-pci device is reset (triggering a full UNMAP). In order to ensure this occurs, trigger ISM device resets from subsystem_reset before triggering the PCI bus reset (which will also trigger vfi