Re: [PATCH v2 3/5] hw/arm/aspeed: Init CPU defaults in a common helper

2024-01-24 Thread Philippe Mathieu-Daudé
On 25/1/24 03:26, Gavin Shan wrote: Hi Phil, On 1/24/24 08:48, Philippe Mathieu-Daudé wrote: Rework aspeed_soc_num_cpus() as a new init_cpus_defaults() helper to reduce code duplication. Signed-off-by: Philippe Mathieu-Daudé ---   hw/arm/aspeed.c | 71

Re: [PATCH v2 3/5] hw/arm/aspeed: Init CPU defaults in a common helper

2024-01-24 Thread Gavin Shan
Hi Phil, On 1/24/24 08:48, Philippe Mathieu-Daudé wrote: Rework aspeed_soc_num_cpus() as a new init_cpus_defaults() helper to reduce code duplication. Signed-off-by: Philippe Mathieu-Daudé --- hw/arm/aspeed.c | 71 +++-- 1 file changed, 28

Re: [PATCH v2 3/5] hw/arm/aspeed: Init CPU defaults in a common helper

2024-01-24 Thread Richard Henderson
On 1/24/24 08:48, Philippe Mathieu-Daudé wrote: Rework aspeed_soc_num_cpus() as a new init_cpus_defaults() helper to reduce code duplication. Signed-off-by: Philippe Mathieu-Daudé --- hw/arm/aspeed.c | 71 +++-- 1 file changed, 28 insertions(+),

Re: [PATCH v2 3/5] hw/arm/aspeed: Init CPU defaults in a common helper

2024-01-23 Thread Cédric Le Goater
On 1/23/24 23:48, Philippe Mathieu-Daudé wrote: Rework aspeed_soc_num_cpus() as a new init_cpus_defaults() helper to reduce code duplication. Signed-off-by: Philippe Mathieu-Daudé --- hw/arm/aspeed.c | 71 +++-- 1 file changed, 28 insertions(+),

[PATCH v2 3/5] hw/arm/aspeed: Init CPU defaults in a common helper

2024-01-23 Thread Philippe Mathieu-Daudé
Rework aspeed_soc_num_cpus() as a new init_cpus_defaults() helper to reduce code duplication. Signed-off-by: Philippe Mathieu-Daudé --- hw/arm/aspeed.c | 71 +++-- 1 file changed, 28 insertions(+), 43 deletions(-) diff --git a/hw/arm/aspeed.c