Re: [PATCH v2 3/5] hw/i386/apic: Simplify apic_get_class()

2023-10-03 Thread Bernhard Beschow
Am 3. Oktober 2023 08:27:26 UTC schrieb "Philippe Mathieu-Daudé" : >Now than apic_get_class() can not fail, remove its s/than/that/ s/can not/can't/ (which is stylistically consistent with "neither" below) Best regards, Bernhard >Error** parameter. It can't return NULL neither, so >simplify

Re: [PATCH v2 3/5] hw/i386/apic: Simplify apic_get_class()

2023-10-03 Thread Peter Xu
On Tue, Oct 03, 2023 at 10:27:26AM +0200, Philippe Mathieu-Daudé wrote: > Now than apic_get_class() can not fail, remove its > Error** parameter. It can't return NULL neither, so > simplify x86_cpu_apic_create(). > > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Peter Xu -- Peter Xu

[PATCH v2 3/5] hw/i386/apic: Simplify apic_get_class()

2023-10-03 Thread Philippe Mathieu-Daudé
Now than apic_get_class() can not fail, remove its Error** parameter. It can't return NULL neither, so simplify x86_cpu_apic_create(). Signed-off-by: Philippe Mathieu-Daudé --- include/hw/i386/apic_internal.h | 2 +- hw/i386/amd_iommu.c | 2 +- hw/i386/intel_iommu.c | 4