Re: [PATCH v2 4/5] hw/arm/aspeed: Add aspeed_eeprom.c

2023-01-17 Thread Peter Delevoryas
On Tue, Jan 17, 2023 at 09:08:57AM +0100, Philippe Mathieu-Daudé wrote: > On 17/1/23 08:39, Cédric Le Goater wrote: > > On 1/17/23 00:56, Peter Delevoryas wrote: > > > - Create aspeed_eeprom.c and aspeed_eeprom.h > > > - Include aspeed_eeprom.c in CONFIG_ASPEED meson source files > > > - Include

Re: [PATCH v2 4/5] hw/arm/aspeed: Add aspeed_eeprom.c

2023-01-17 Thread Peter Delevoryas
On Tue, Jan 17, 2023 at 08:39:06AM +0100, Cédric Le Goater wrote: > On 1/17/23 00:56, Peter Delevoryas wrote: > > - Create aspeed_eeprom.c and aspeed_eeprom.h > > - Include aspeed_eeprom.c in CONFIG_ASPEED meson source files > > - Include aspeed_eeprom.h in aspeed.c > > - Add fby35_bmc_fruid data

Re: [PATCH v2 4/5] hw/arm/aspeed: Add aspeed_eeprom.c

2023-01-17 Thread Cédric Le Goater
+#ifndef ASPEED_EEPROM_H +#define ASPEED_EEPROM_H + +#include "qemu/osdep.h" + +extern const uint8_t fby35_bmc_fruid[]; may be define the array with an explicit size to avoid the size variable ? I don't see any good solution.  /* Return rom_size and set rombufptr, or return 0 */  size_t

Re: [PATCH v2 4/5] hw/arm/aspeed: Add aspeed_eeprom.c

2023-01-17 Thread Philippe Mathieu-Daudé
On 17/1/23 08:39, Cédric Le Goater wrote: On 1/17/23 00:56, Peter Delevoryas wrote: - Create aspeed_eeprom.c and aspeed_eeprom.h - Include aspeed_eeprom.c in CONFIG_ASPEED meson source files - Include aspeed_eeprom.h in aspeed.c - Add fby35_bmc_fruid data - Use new at24c_eeprom_init_rom helper

Re: [PATCH v2 4/5] hw/arm/aspeed: Add aspeed_eeprom.c

2023-01-16 Thread Cédric Le Goater
On 1/17/23 00:56, Peter Delevoryas wrote: - Create aspeed_eeprom.c and aspeed_eeprom.h - Include aspeed_eeprom.c in CONFIG_ASPEED meson source files - Include aspeed_eeprom.h in aspeed.c - Add fby35_bmc_fruid data - Use new at24c_eeprom_init_rom helper to initialize BMC FRUID EEPROM with data

[PATCH v2 4/5] hw/arm/aspeed: Add aspeed_eeprom.c

2023-01-16 Thread Peter Delevoryas
- Create aspeed_eeprom.c and aspeed_eeprom.h - Include aspeed_eeprom.c in CONFIG_ASPEED meson source files - Include aspeed_eeprom.h in aspeed.c - Add fby35_bmc_fruid data - Use new at24c_eeprom_init_rom helper to initialize BMC FRUID EEPROM with data from aspeed_eeprom.c wget