Re: [PATCH v2 5/6] macio: don't reference serial_hd() directly within the device

2020-11-10 Thread Mark Cave-Ayland
On 09/11/2020 10:02, Thomas Huth wrote: Just out of interest how did you find this? My new workflow involves a local "make check" with all ppc targets and a pass through Travis-CI and it didn't show up there for me (or indeed Peter's pre-merge tests). I've found it with the

Re: [PATCH v2 5/6] macio: don't reference serial_hd() directly within the device

2020-11-09 Thread Thomas Huth
On 06/11/2020 08.35, Mark Cave-Ayland wrote: > On 05/11/2020 05:31, Thomas Huth wrote: > >>> (goes and looks) >>> >>> Ah okay it appears to be because the object property link to the PIC is >>> missing, which is to be expected as it is only present on the Mac machines. >>> >>> With the latest

Re: [PATCH v2 5/6] macio: don't reference serial_hd() directly within the device

2020-11-05 Thread Mark Cave-Ayland
On 05/11/2020 05:31, Thomas Huth wrote: (goes and looks) Ah okay it appears to be because the object property link to the PIC is missing, which is to be expected as it is only present on the Mac machines. With the latest round of QOM updates I can see the solution but it's probably a bit much

Re: [PATCH v2 5/6] macio: don't reference serial_hd() directly within the device

2020-11-04 Thread Markus Armbruster
Thomas Huth writes: > On 04/11/2020 15.16, BALATON Zoltan wrote: >> On Wed, 4 Nov 2020, Thomas Huth wrote: >>> On 26/09/2020 16.02, Mark Cave-Ayland wrote: Instead use qdev_prop_set_chr() to configure the ESCC serial chardevs at the Mac Old World and New World machine level.

Re: [PATCH v2 5/6] macio: don't reference serial_hd() directly within the device

2020-11-04 Thread Thomas Huth
On 04/11/2020 20.29, Mark Cave-Ayland wrote: > On 04/11/2020 12:47, Thomas Huth wrote: > >> On 26/09/2020 16.02, Mark Cave-Ayland wrote: >>> Instead use qdev_prop_set_chr() to configure the ESCC serial chardevs at the >>> Mac Old World and New World machine level. >>> >>> Also remove the now

Re: [PATCH v2 5/6] macio: don't reference serial_hd() directly within the device

2020-11-04 Thread Mark Cave-Ayland
On 04/11/2020 12:47, Thomas Huth wrote: On 26/09/2020 16.02, Mark Cave-Ayland wrote: Instead use qdev_prop_set_chr() to configure the ESCC serial chardevs at the Mac Old World and New World machine level. Also remove the now obsolete comment referring to the use of serial_hd() and the setting

Re: [PATCH v2 5/6] macio: don't reference serial_hd() directly within the device

2020-11-04 Thread Thomas Huth
On 04/11/2020 15.16, BALATON Zoltan wrote: > On Wed, 4 Nov 2020, Thomas Huth wrote: >> On 26/09/2020 16.02, Mark Cave-Ayland wrote: >>> Instead use qdev_prop_set_chr() to configure the ESCC serial chardevs at the >>> Mac Old World and New World machine level. >>> >>> Also remove the now obsolete

Re: [PATCH v2 5/6] macio: don't reference serial_hd() directly within the device

2020-11-04 Thread BALATON Zoltan via
On Wed, 4 Nov 2020, BALATON Zoltan via wrote: On Wed, 4 Nov 2020, Thomas Huth wrote: On 26/09/2020 16.02, Mark Cave-Ayland wrote: Instead use qdev_prop_set_chr() to configure the ESCC serial chardevs at the Mac Old World and New World machine level. Also remove the now obsolete comment

Re: [PATCH v2 5/6] macio: don't reference serial_hd() directly within the device

2020-11-04 Thread BALATON Zoltan via
On Wed, 4 Nov 2020, Thomas Huth wrote: > On 26/09/2020 16.02, Mark Cave-Ayland wrote: >> Instead use qdev_prop_set_chr() to configure the ESCC serial chardevs at the >> Mac Old World and New World machine level. >> >> Also remove the now obsolete comment referring to the use of serial_hd() and >>

Re: [PATCH v2 5/6] macio: don't reference serial_hd() directly within the device

2020-11-04 Thread Thomas Huth
On 26/09/2020 16.02, Mark Cave-Ayland wrote: > Instead use qdev_prop_set_chr() to configure the ESCC serial chardevs at the > Mac Old World and New World machine level. > > Also remove the now obsolete comment referring to the use of serial_hd() and > the setting of user_creatable to false

[PATCH v2 5/6] macio: don't reference serial_hd() directly within the device

2020-09-26 Thread Mark Cave-Ayland
Instead use qdev_prop_set_chr() to configure the ESCC serial chardevs at the Mac Old World and New World machine level. Also remove the now obsolete comment referring to the use of serial_hd() and the setting of user_creatable to false accordingly. Signed-off-by: Mark Cave-Ayland ---