Re: [PATCH v2 52/53] migration/rdma: Use error_report() & friends instead of stderr

2023-10-06 Thread Zhijian Li (Fujitsu)
On 28/09/2023 21:20, Markus Armbruster wrote: > error_report() obeys -msg, reports the current error location if any, > and reports to the current monitor if any. Reporting to stderr > directly with fprintf() or perror() is wrong, because it loses all > this. > > Fix the offenders. Bonus:

Re: [PATCH v2 52/53] migration/rdma: Use error_report() & friends instead of stderr

2023-10-05 Thread Juan Quintela
Markus Armbruster wrote: > error_report() obeys -msg, reports the current error location if any, > and reports to the current monitor if any. Reporting to stderr > directly with fprintf() or perror() is wrong, because it loses all > this. > > Fix the offenders. Bonus: resolves a FIXME about

Re: [PATCH v2 52/53] migration/rdma: Use error_report() & friends instead of stderr

2023-10-04 Thread Fabiano Rosas
Markus Armbruster writes: > Fabiano Rosas writes: > >> Markus Armbruster writes: >> >>> error_report() obeys -msg, reports the current error location if any, >>> and reports to the current monitor if any. Reporting to stderr >>> directly with fprintf() or perror() is wrong, because it loses

Re: [PATCH v2 52/53] migration/rdma: Use error_report() & friends instead of stderr

2023-10-04 Thread Markus Armbruster
Fabiano Rosas writes: > Markus Armbruster writes: > >> error_report() obeys -msg, reports the current error location if any, >> and reports to the current monitor if any. Reporting to stderr >> directly with fprintf() or perror() is wrong, because it loses all >> this. >> >> Fix the offenders.

Re: [PATCH v2 52/53] migration/rdma: Use error_report() & friends instead of stderr

2023-09-29 Thread Fabiano Rosas
Markus Armbruster writes: > error_report() obeys -msg, reports the current error location if any, > and reports to the current monitor if any. Reporting to stderr > directly with fprintf() or perror() is wrong, because it loses all > this. > > Fix the offenders. Bonus: resolves a FIXME about

[PATCH v2 52/53] migration/rdma: Use error_report() & friends instead of stderr

2023-09-28 Thread Markus Armbruster
error_report() obeys -msg, reports the current error location if any, and reports to the current monitor if any. Reporting to stderr directly with fprintf() or perror() is wrong, because it loses all this. Fix the offenders. Bonus: resolves a FIXME about problematic use of errno.