Re: [PATCH v2 9/9] target/arm: Convert Neon one-register-and-immediate insns to decodetree

2020-06-02 Thread Peter Maydell
On Tue, 2 Jun 2020 at 00:32, Richard Henderson wrote: > It might be clearer to use dup_const for each case, which would more closely > match the pseudocode. E.g. here, > > return dup_const(MO_16, imm << 8); > > > +imm |= (imm << 8) | (imm << 16) | (imm << 24); > > return

Re: [PATCH v2 9/9] target/arm: Convert Neon one-register-and-immediate insns to decodetree

2020-06-01 Thread Richard Henderson
On 5/22/20 7:55 AM, Peter Maydell wrote: > Convert the insns in the one-register-and-immediate group to decodetree. > > In the new decode, our asimd_imm_const() function returns a 64-bit value > rather than a 32-bit one, which means we don't need to treat cmode=14 op=1 > as a special case in the

[PATCH v2 9/9] target/arm: Convert Neon one-register-and-immediate insns to decodetree

2020-05-22 Thread Peter Maydell
Convert the insns in the one-register-and-immediate group to decodetree. In the new decode, our asimd_imm_const() function returns a 64-bit value rather than a 32-bit one, which means we don't need to treat cmode=14 op=1 as a special case in the decoder (it is the only encoding where the two