Re: [RESEND PATCH v21 3/6] ACPI: Add APEI GHES table generation support

2019-11-27 Thread gengdongjiu
On 2019/11/25 17:48, Igor Mammedov wrote: >>>.. >>> bios_linker_loader_add_pointer(linker, ACPI_BUILD_TABLE_FILE, >>> ACPI_GHES_ERROR_STATUS_ADDRESS_OFFSET(hest_start, source_id), >>> sizeof(uint64_t), ACPI_GHES_ERRORS_FW_CFG_FILE, >>> source_id *

Re: [RESEND PATCH v21 3/6] ACPI: Add APEI GHES table generation support

2019-11-25 Thread Igor Mammedov
On Mon, 18 Nov 2019 08:21:18 -0500 "Michael S. Tsirkin" wrote: > On Mon, Nov 18, 2019 at 09:18:01PM +0800, gengdongjiu wrote: > > On 2019/11/18 20:49, gengdongjiu wrote: > > >>> + */ > > >>> +build_append_int_noprefix(table_data, source_id, 2); > > >>> +/* Related Source Id */ > >

Re: [RESEND PATCH v21 3/6] ACPI: Add APEI GHES table generation support

2019-11-25 Thread Igor Mammedov
On Fri, 22 Nov 2019 15:42:52 + Beata Michalska wrote: > Hi Xiang, > > On Mon, 11 Nov 2019 at 01:48, Xiang Zheng wrote: > > > > From: Dongjiu Geng > > > > This patch implements APEI GHES Table generation via fw_cfg blobs. Now > > it only supports ARMv8 SEA, a type of GHESv2 error source.

Re: [RESEND PATCH v21 3/6] ACPI: Add APEI GHES table generation support

2019-11-22 Thread Beata Michalska
Hi, On Mon, 18 Nov 2019 at 12:50, gengdongjiu wrote: > > Hi,Igor, >Thanks for you review and time. > > > > >> +/* > >> + * Type: > >> + * Generic Hardware Error Source version 2(GHESv2 - Type 10) > >> + */ > >> +build_append_int_noprefix(table_data, > >>

Re: [RESEND PATCH v21 3/6] ACPI: Add APEI GHES table generation support

2019-11-22 Thread Beata Michalska
Hi Xiang, On Mon, 11 Nov 2019 at 01:48, Xiang Zheng wrote: > > From: Dongjiu Geng > > This patch implements APEI GHES Table generation via fw_cfg blobs. Now > it only supports ARMv8 SEA, a type of GHESv2 error source. Afterwards, > we can extend the supported types if needed. For the CPER

Re: [RESEND PATCH v21 3/6] ACPI: Add APEI GHES table generation support

2019-11-18 Thread gengdongjiu
On 2019/11/18 21:21, Michael S. Tsirkin wrote: >> If use offset relative to GAS structure, the code does not easily extend to >> support more Generic Hardware Error Source. >> if use offset relative to hest_start, just use a loop, the code can support >> more error source, for example: >> for

Re: [RESEND PATCH v21 3/6] ACPI: Add APEI GHES table generation support

2019-11-18 Thread Michael S. Tsirkin
On Mon, Nov 18, 2019 at 09:18:01PM +0800, gengdongjiu wrote: > On 2019/11/18 20:49, gengdongjiu wrote: > >>> + */ > >>> +build_append_int_noprefix(table_data, source_id, 2); > >>> +/* Related Source Id */ > >>> +build_append_int_noprefix(table_data, 0x, 2); > >>> +/* Flags

Re: [RESEND PATCH v21 3/6] ACPI: Add APEI GHES table generation support

2019-11-18 Thread gengdongjiu
On 2019/11/18 20:49, gengdongjiu wrote: >>> + */ >>> +build_append_int_noprefix(table_data, source_id, 2); >>> +/* Related Source Id */ >>> +build_append_int_noprefix(table_data, 0x, 2); >>> +/* Flags */ >>> +build_append_int_noprefix(table_data, 0, 1); >>> +/*

Re: [RESEND PATCH v21 3/6] ACPI: Add APEI GHES table generation support

2019-11-18 Thread gengdongjiu
Hi,Igor, Thanks for you review and time. > >> +/* >> + * Type: >> + * Generic Hardware Error Source version 2(GHESv2 - Type 10) >> + */ >> +build_append_int_noprefix(table_data, >> ACPI_GHES_SOURCE_GENERIC_ERROR_V2, 2); >> +/* >> + * Source Id > >> + *

Re: [RESEND PATCH v21 3/6] ACPI: Add APEI GHES table generation support

2019-11-15 Thread gengdongjiu
> On Fri, 15 Nov 2019 14:32:47 + > gengdongjiu wrote: > > > > > + */ > > > > +static void acpi_ghes_build_notify(GArray *table, const uint8_t > > > > +type) > > > > > > typically format should be build_WHAT(), so > > > build_ghes_hw_error_notification() > > > > > > And I'd move this out

Re: [RESEND PATCH v21 3/6] ACPI: Add APEI GHES table generation support

2019-11-15 Thread Igor Mammedov
On Fri, 15 Nov 2019 14:32:47 + gengdongjiu wrote: > > > + */ > > > +static void acpi_ghes_build_notify(GArray *table, const uint8_t type) > > > > typically format should be build_WHAT(), so > > build_ghes_hw_error_notification() > > > > And I'd move this out into its own patch. > > this

Re: [RESEND PATCH v21 3/6] ACPI: Add APEI GHES table generation support

2019-11-15 Thread gengdongjiu
> > + */ > > +static void acpi_ghes_build_notify(GArray *table, const uint8_t type) > > typically format should be build_WHAT(), so > build_ghes_hw_error_notification() > > And I'd move this out into its own patch. > this applies to other trivial in-depended sub-tables, that take all data >

Re: [RESEND PATCH v21 3/6] ACPI: Add APEI GHES table generation support

2019-11-15 Thread Igor Mammedov
On Mon, 11 Nov 2019 09:40:45 +0800 Xiang Zheng wrote: > From: Dongjiu Geng > > This patch implements APEI GHES Table generation via fw_cfg blobs. Now > it only supports ARMv8 SEA, a type of GHESv2 error source. Afterwards, > we can extend the supported types if needed. For the CPER section, >

[RESEND PATCH v21 3/6] ACPI: Add APEI GHES table generation support

2019-11-10 Thread Xiang Zheng
From: Dongjiu Geng This patch implements APEI GHES Table generation via fw_cfg blobs. Now it only supports ARMv8 SEA, a type of GHESv2 error source. Afterwards, we can extend the supported types if needed. For the CPER section, currently it is memory section because kernel mainly wants userspace

Re: [PATCH v21 3/6] ACPI: Add APEI GHES table generation support

2019-11-10 Thread Xiang Zheng
On 2019/11/8 16:11, gengdongjiu wrote: > On 2019/11/4 20:14, Xiang Zheng wrote: >> From: Dongjiu Geng >> >> This patch implements APEI GHES Table generation via fw_cfg blobs. Now >> it only supports ARMv8 SEA, a type of GHESv2 error source. Afterwards, >> we can extend the supported types if

Re: [PATCH v21 3/6] ACPI: Add APEI GHES table generation support

2019-11-08 Thread gengdongjiu
On 2019/11/4 20:14, Xiang Zheng wrote: > From: Dongjiu Geng > > This patch implements APEI GHES Table generation via fw_cfg blobs. Now > it only supports ARMv8 SEA, a type of GHESv2 error source. Afterwards, > we can extend the supported types if needed. For the CPER section, > currently it is

[PATCH v21 3/6] ACPI: Add APEI GHES table generation support

2019-11-04 Thread Xiang Zheng
From: Dongjiu Geng This patch implements APEI GHES Table generation via fw_cfg blobs. Now it only supports ARMv8 SEA, a type of GHESv2 error source. Afterwards, we can extend the supported types if needed. For the CPER section, currently it is memory section because kernel mainly wants userspace