Re: [PATCH v21 QEMU 4/5] virtio-balloon: Implement support for page poison tracking feature

2020-04-24 Thread David Hildenbrand
On 24.04.20 09:53, Cornelia Huck wrote: > On Fri, 24 Apr 2020 09:07:25 +0200 > David Hildenbrand wrote: > GlobalProperty hw_compat_4_2[] = { { "virtio-blk-device", "queue-size", "128"}, { "virtio-scsi-device", "virtqueue_size", "128"}, >>> >>> Okay, so the bit above

Re: [PATCH v21 QEMU 4/5] virtio-balloon: Implement support for page poison tracking feature

2020-04-24 Thread Cornelia Huck
On Fri, 24 Apr 2020 09:07:25 +0200 David Hildenbrand wrote: > >> GlobalProperty hw_compat_4_2[] = { > >> { "virtio-blk-device", "queue-size", "128"}, > >> { "virtio-scsi-device", "virtqueue_size", "128"}, > > > > Okay, so the bit above is for after 5_0 is released then? Is there a

Re: [PATCH v21 QEMU 4/5] virtio-balloon: Implement support for page poison tracking feature

2020-04-24 Thread David Hildenbrand
>> GlobalProperty hw_compat_4_2[] = { >> { "virtio-blk-device", "queue-size", "128"}, >> { "virtio-scsi-device", "virtqueue_size", "128"}, > > Okay, so the bit above is for after 5_0 is released then? Is there a Yes. > way to queue up a reminder or something so we get to it when the

Re: [PATCH v21 QEMU 4/5] virtio-balloon: Implement support for page poison tracking feature

2020-04-23 Thread Alexander Duyck
On Thu, Apr 23, 2020 at 9:02 AM David Hildenbrand wrote: > > On 23.04.20 16:46, Alexander Duyck wrote: > > On Thu, Apr 23, 2020 at 1:11 AM David Hildenbrand wrote: > >> > >> On 22.04.20 20:21, Alexander Duyck wrote: > >>> From: Alexander Duyck > >>> > >>> We need to make certain to advertise

Re: [PATCH v21 QEMU 4/5] virtio-balloon: Implement support for page poison tracking feature

2020-04-23 Thread David Hildenbrand
On 23.04.20 16:46, Alexander Duyck wrote: > On Thu, Apr 23, 2020 at 1:11 AM David Hildenbrand wrote: >> >> On 22.04.20 20:21, Alexander Duyck wrote: >>> From: Alexander Duyck >>> >>> We need to make certain to advertise support for page poison tracking if >>> we want to actually get data on if

Re: [PATCH v21 QEMU 4/5] virtio-balloon: Implement support for page poison tracking feature

2020-04-23 Thread Alexander Duyck
On Thu, Apr 23, 2020 at 1:11 AM David Hildenbrand wrote: > > On 22.04.20 20:21, Alexander Duyck wrote: > > From: Alexander Duyck > > > > We need to make certain to advertise support for page poison tracking if > > we want to actually get data on if the guest will be poisoning pages. > > > > Add

Re: [PATCH v21 QEMU 4/5] virtio-balloon: Implement support for page poison tracking feature

2020-04-23 Thread David Hildenbrand
On 22.04.20 20:21, Alexander Duyck wrote: > From: Alexander Duyck > > We need to make certain to advertise support for page poison tracking if > we want to actually get data on if the guest will be poisoning pages. > > Add a value for tracking the poison value being used if page poisoning is >

[PATCH v21 QEMU 4/5] virtio-balloon: Implement support for page poison tracking feature

2020-04-22 Thread Alexander Duyck
From: Alexander Duyck We need to make certain to advertise support for page poison tracking if we want to actually get data on if the guest will be poisoning pages. Add a value for tracking the poison value being used if page poisoning is enabled. With this we can determine if we will need to