Re: [PATCH v28 03/17] vfio: Add save and load functions for VFIO PCI devices

2020-10-24 Thread Yan Zhao
On Sat, Oct 24, 2020 at 08:16:30AM -0600, Alex Williamson wrote: > On Sat, 24 Oct 2020 19:53:39 +0800 > Yan Zhao wrote: > > > hi > > when I migrating VFs, the PCI_COMMAND is not properly saved. and the > > target side would meet below bug > > root@tester:~# [ 189.360671] ++>> reset start

Re: [PATCH v28 03/17] vfio: Add save and load functions for VFIO PCI devices

2020-10-24 Thread Alex Williamson
On Sun, 25 Oct 2020 01:18:37 +0530 Kirti Wankhede wrote: > On 10/24/2020 7:46 PM, Alex Williamson wrote: > > On Sat, 24 Oct 2020 19:53:39 +0800 > > Yan Zhao wrote: > > > >> hi > >> when I migrating VFs, the PCI_COMMAND is not properly saved. and the > >> target side would meet below bug > >>

Re: [PATCH v28 03/17] vfio: Add save and load functions for VFIO PCI devices

2020-10-24 Thread Kirti Wankhede
On 10/24/2020 7:46 PM, Alex Williamson wrote: On Sat, 24 Oct 2020 19:53:39 +0800 Yan Zhao wrote: hi when I migrating VFs, the PCI_COMMAND is not properly saved. and the target side would meet below bug root@tester:~# [ 189.360671] ++>> reset starts here: iavf_reset_task !!! [ 199

Re: [PATCH v28 03/17] vfio: Add save and load functions for VFIO PCI devices

2020-10-24 Thread Alex Williamson
On Sat, 24 Oct 2020 19:53:39 +0800 Yan Zhao wrote: > hi > when I migrating VFs, the PCI_COMMAND is not properly saved. and the > target side would meet below bug > root@tester:~# [ 189.360671] ++>> reset starts here: iavf_reset_task > !!! > [ 199.360798] iavf :00:04.0: Reset never

Re: [PATCH v28 03/17] vfio: Add save and load functions for VFIO PCI devices

2020-10-24 Thread Yan Zhao
hi when I migrating VFs, the PCI_COMMAND is not properly saved. and the target side would meet below bug root@tester:~# [ 189.360671] ++>> reset starts here: iavf_reset_task !!! [ 199.360798] iavf :00:04.0: Reset never finished (0) [ 199.380504] kernel BUG at drivers/pci/msi.c:352!

[PATCH v28 03/17] vfio: Add save and load functions for VFIO PCI devices

2020-10-23 Thread Kirti Wankhede
Added functions to save and restore PCI device specific data, specifically config space of PCI device. Signed-off-by: Kirti Wankhede Reviewed-by: Neo Jia --- hw/vfio/pci.c | 48 +++ include/hw/vfio/vfio-common.h | 2 ++ 2 files changed, 5