Re: [PATCH v3] hw/block/nvme: fix lbaf formats initialization

2021-04-21 Thread Philippe Mathieu-Daudé
On 4/16/21 1:59 PM, Gollu Appalanaidu wrote: > Currently LBAF formats are being intialized based on metadata > size if and only if nvme-ns "ms" parameter is non-zero value. > Since FormatNVM command being supported device parameter "ms" > may not be the criteria to initialize the supported LBAFs. >

Re: [PATCH v3] hw/block/nvme: fix lbaf formats initialization

2021-04-21 Thread Gollu Appalanaidu
On Tue, Apr 20, 2021 at 09:47:00PM +0200, Klaus Jensen wrote: On Apr 16 17:29, Gollu Appalanaidu wrote: Currently LBAF formats are being intialized based on metadata size if and only if nvme-ns "ms" parameter is non-zero value. Since FormatNVM command being supported device parameter "ms" may no

Re: [PATCH v3] hw/block/nvme: fix lbaf formats initialization

2021-04-20 Thread Klaus Jensen
On Apr 16 17:29, Gollu Appalanaidu wrote: Currently LBAF formats are being intialized based on metadata size if and only if nvme-ns "ms" parameter is non-zero value. Since FormatNVM command being supported device parameter "ms" may not be the criteria to initialize the supported LBAFs. Signed-of

[PATCH v3] hw/block/nvme: fix lbaf formats initialization

2021-04-16 Thread Gollu Appalanaidu
Currently LBAF formats are being intialized based on metadata size if and only if nvme-ns "ms" parameter is non-zero value. Since FormatNVM command being supported device parameter "ms" may not be the criteria to initialize the supported LBAFs. Signed-off-by: Gollu Appalanaidu --- -v3: Remove "ms