Re: [PATCH v3] i440fx/acpi: do not add hotplug related amls for cold plugged bridges

2020-09-11 Thread Ani Sinha
On Fri, Sep 11, 2020 at 9:39 PM Michael S. Tsirkin wrote: > > On Fri, Sep 11, 2020 at 09:35:42PM +0530, Ani Sinha wrote: > > On Fri, Sep 11, 2020 at 9:22 PM Michael S. Tsirkin wrote: > > > > > > On Thu, Sep 10, 2020 at 12:19:19AM +0530, Ani Sinha wrote: > > > > On Sep 10, 2020, 00:00 +0530, Ani

Re: [PATCH v3] i440fx/acpi: do not add hotplug related amls for cold plugged bridges

2020-09-11 Thread Ani Sinha
On Fri, Sep 11, 2020 at 9:45 PM Ani Sinha wrote: > > On Fri, Sep 11, 2020 at 9:39 PM Michael S. Tsirkin wrote: > > > > On Fri, Sep 11, 2020 at 09:35:42PM +0530, Ani Sinha wrote: > > > On Fri, Sep 11, 2020 at 9:22 PM Michael S. Tsirkin > > > wrote: > > > > > > > > On Thu, Sep 10, 2020 at

Re: [PATCH v3] i440fx/acpi: do not add hotplug related amls for cold plugged bridges

2020-09-11 Thread Ani Sinha
On Fri, Sep 11, 2020 at 9:39 PM Michael S. Tsirkin wrote: > > On Fri, Sep 11, 2020 at 09:35:42PM +0530, Ani Sinha wrote: > > On Fri, Sep 11, 2020 at 9:22 PM Michael S. Tsirkin wrote: > > > > > > On Thu, Sep 10, 2020 at 12:19:19AM +0530, Ani Sinha wrote: > > > > On Sep 10, 2020, 00:00 +0530, Ani

Re: [PATCH v3] i440fx/acpi: do not add hotplug related amls for cold plugged bridges

2020-09-11 Thread Michael S. Tsirkin
On Fri, Sep 11, 2020 at 09:35:42PM +0530, Ani Sinha wrote: > On Fri, Sep 11, 2020 at 9:22 PM Michael S. Tsirkin wrote: > > > > On Thu, Sep 10, 2020 at 12:19:19AM +0530, Ani Sinha wrote: > > > On Sep 10, 2020, 00:00 +0530, Ani Sinha , wrote: > > > > > > On Sep 9, 2020, 23:20 +0530, Julia

Re: [PATCH v3] i440fx/acpi: do not add hotplug related amls for cold plugged bridges

2020-09-11 Thread Ani Sinha
On Fri, Sep 11, 2020 at 9:22 PM Michael S. Tsirkin wrote: > > On Thu, Sep 10, 2020 at 12:19:19AM +0530, Ani Sinha wrote: > > On Sep 10, 2020, 00:00 +0530, Ani Sinha , wrote: > > > > On Sep 9, 2020, 23:20 +0530, Julia Suvorova , wrote: > > > > On Fri, Sep 4, 2020 at 6:10 PM Ani Sinha

Re: [PATCH v3] i440fx/acpi: do not add hotplug related amls for cold plugged bridges

2020-09-11 Thread Michael S. Tsirkin
On Thu, Sep 10, 2020 at 12:19:19AM +0530, Ani Sinha wrote: > On Sep 10, 2020, 00:00 +0530, Ani Sinha , wrote: > > On Sep 9, 2020, 23:20 +0530, Julia Suvorova , wrote: > > On Fri, Sep 4, 2020 at 6:10 PM Ani Sinha wrote: > > > > Cold plugged bridges are not hot

Re: [PATCH v3] i440fx/acpi: do not add hotplug related amls for cold plugged bridges

2020-09-09 Thread Ani Sinha
On Sep 10, 2020, 00:00 +0530, Ani Sinha , wrote: > On Sep 9, 2020, 23:20 +0530, Julia Suvorova , wrote: > > On Fri, Sep 4, 2020 at 6:10 PM Ani Sinha wrote: > > > > > > Cold plugged bridges are not hot unpluggable, even when their hotplug > > > property (acpi-pci-hotplug-with-bridge-support) is

Re: [PATCH v3] i440fx/acpi: do not add hotplug related amls for cold plugged bridges

2020-09-09 Thread Ani Sinha
On Sep 9, 2020, 23:20 +0530, Julia Suvorova , wrote: > On Fri, Sep 4, 2020 at 6:10 PM Ani Sinha wrote: > > > > Cold plugged bridges are not hot unpluggable, even when their hotplug > > property (acpi-pci-hotplug-with-bridge-support) is turned off. Please see > > the function

Re: [PATCH v3] i440fx/acpi: do not add hotplug related amls for cold plugged bridges

2020-09-09 Thread Julia Suvorova
On Fri, Sep 4, 2020 at 6:10 PM Ani Sinha wrote: > > Cold plugged bridges are not hot unpluggable, even when their hotplug > property (acpi-pci-hotplug-with-bridge-support) is turned off. Please see > the function acpi_pcihp_pc_no_hotplug() (thanks Julia). However, with > the current

Re: [PATCH v3] i440fx/acpi: do not add hotplug related amls for cold plugged bridges

2020-09-09 Thread Ani Sinha
Gentle reminder to kindly review this patch :-) @Julia Suvorova @Michael S. Tsirkin On Mon, Sep 7, 2020 at 6:47 PM Ani Sinha wrote: > > Julia Michael, > > Can you please provide your inputs on this one and the corresponding unit > tests? > > On Fri, Sep 4, 2020 at 9:40 PM Ani Sinha wrote: >>

Re: [PATCH v3] i440fx/acpi: do not add hotplug related amls for cold plugged bridges

2020-09-07 Thread Ani Sinha
Julia Michael, Can you please provide your inputs on this one and the corresponding unit tests? On Fri, Sep 4, 2020 at 9:40 PM Ani Sinha wrote: > Cold plugged bridges are not hot unpluggable, even when their hotplug > > property (acpi-pci-hotplug-with-bridge-support) is turned off. Please see

[PATCH v3] i440fx/acpi: do not add hotplug related amls for cold plugged bridges

2020-09-04 Thread Ani Sinha
Cold plugged bridges are not hot unpluggable, even when their hotplug property (acpi-pci-hotplug-with-bridge-support) is turned off. Please see the function acpi_pcihp_pc_no_hotplug() (thanks Julia). However, with the current implementaton, windows would try to hot-unplug a pci bridge when it's