Re: [PATCH v3] net: remove an assert call in eth_get_gso_type

2020-10-27 Thread Jason Wang
On 2020/10/26 下午5:59, Peter Maydell wrote: On Wed, 21 Oct 2020 at 10:23, P J P wrote: +-- On Wed, 21 Oct 2020, Jason Wang wrote --+ | It should not be a guest error, since guest is allowed to send a packet | other than IPV4(6). * Ah...sigh! :( * I very hesitantly used guest_error mask,

Re: [PATCH v3] net: remove an assert call in eth_get_gso_type

2020-10-26 Thread Peter Maydell
On Wed, 21 Oct 2020 at 10:23, P J P wrote: > > +-- On Wed, 21 Oct 2020, Jason Wang wrote --+ > | It should not be a guest error, since guest is allowed to send a packet > | other than IPV4(6). > > * Ah...sigh! :( > > * I very hesitantly used guest_error mask, since it was g_assert-ing before. >

Re: [PATCH v3] net: remove an assert call in eth_get_gso_type

2020-10-25 Thread Jason Wang
On 2020/10/21 下午5:23, P J P wrote: +-- On Wed, 21 Oct 2020, Jason Wang wrote --+ | It should not be a guest error, since guest is allowed to send a packet | other than IPV4(6). * Ah...sigh! :( * I very hesitantly used guest_error mask, since it was g_assert-ing before. To me both

Re: [PATCH v3] net: remove an assert call in eth_get_gso_type

2020-10-21 Thread P J P
+-- On Wed, 21 Oct 2020, Jason Wang wrote --+ | It should not be a guest error, since guest is allowed to send a packet | other than IPV4(6). * Ah...sigh! :( * I very hesitantly used guest_error mask, since it was g_assert-ing before. To me both guest_error and log_unimp seem mismatching.

Re: [PATCH v3] net: remove an assert call in eth_get_gso_type

2020-10-21 Thread Jason Wang
On 2020/10/21 下午2:05, P J P wrote: From: Prasad J Pandit eth_get_gso_type() routine returns segmentation offload type based on L3 protocol type. It calls g_assert_not_reached if L3 protocol is unknown, making the following return statement unreachable. Remove the g_assert call, it maybe

[PATCH v3] net: remove an assert call in eth_get_gso_type

2020-10-21 Thread P J P
From: Prasad J Pandit eth_get_gso_type() routine returns segmentation offload type based on L3 protocol type. It calls g_assert_not_reached if L3 protocol is unknown, making the following return statement unreachable. Remove the g_assert call, it maybe triggered by a guest user. Reported-by: