Re: [PATCH v3 02/11] 9pfs: require msize >= 4096

2020-01-17 Thread Christian Schoenebeck
On Freitag, 17. Januar 2020 16:15:37 CET Greg Kurz wrote: > > > Hmm... this patch does a sanity check on 'count', not on 'msize'... > > > > Yes ... :) > > > > > I mean no matter what msize is, clipping count to msize - 11 gives a > > > chance to stop processing the entries before overflowing the

Re: [PATCH v3 02/11] 9pfs: require msize >= 4096

2020-01-17 Thread Greg Kurz
On Fri, 17 Jan 2020 13:01:30 +0100 Christian Schoenebeck wrote: > On Freitag, 17. Januar 2020 11:24:21 CET Greg Kurz wrote: > > On Thu, 16 Jan 2020 22:39:19 +0100 > > > > Christian Schoenebeck wrote: > > > On Donnerstag, 16. Januar 2020 19:07:48 CET Greg Kurz wrote: > > > > > The point here was

Re: [PATCH v3 02/11] 9pfs: require msize >= 4096

2020-01-17 Thread Christian Schoenebeck
On Freitag, 17. Januar 2020 11:24:21 CET Greg Kurz wrote: > On Thu, 16 Jan 2020 22:39:19 +0100 > > Christian Schoenebeck wrote: > > On Donnerstag, 16. Januar 2020 19:07:48 CET Greg Kurz wrote: > > > > The point here was that there must be some kind of absolute minimum > > > > msize, > > > > > >

Re: [PATCH v3 02/11] 9pfs: require msize >= 4096

2020-01-17 Thread Greg Kurz
On Thu, 16 Jan 2020 22:39:19 +0100 Christian Schoenebeck wrote: > On Donnerstag, 16. Januar 2020 19:07:48 CET Greg Kurz wrote: > > > The point here was that there must be some kind of absolute minimum msize, > > > > Then the absolute minimum size is 7, the size of the header part that is > > com

Re: [PATCH v3 02/11] 9pfs: require msize >= 4096

2020-01-16 Thread Christian Schoenebeck
On Donnerstag, 16. Januar 2020 19:07:48 CET Greg Kurz wrote: > > The point here was that there must be some kind of absolute minimum msize, > > Then the absolute minimum size is 7, the size of the header part that is > common to all messages: > > size[4] Message tag[2] > > > even though the prot

Re: [PATCH v3 02/11] 9pfs: require msize >= 4096

2020-01-16 Thread Greg Kurz
On Thu, 16 Jan 2020 17:16:07 +0100 Christian Schoenebeck wrote: > On Donnerstag, 16. Januar 2020 14:15:03 CET Greg Kurz wrote: > > On Mon, 13 Jan 2020 23:21:04 +0100 > > > > Christian Schoenebeck wrote: > > > A client establishes a session by sending a Tversion request along with > > > a 'msize

Re: [PATCH v3 02/11] 9pfs: require msize >= 4096

2020-01-16 Thread Christian Schoenebeck
On Donnerstag, 16. Januar 2020 14:15:03 CET Greg Kurz wrote: > On Mon, 13 Jan 2020 23:21:04 +0100 > > Christian Schoenebeck wrote: > > A client establishes a session by sending a Tversion request along with > > a 'msize' parameter which client uses to suggest server a maximum > > message size eve

Re: [PATCH v3 02/11] 9pfs: require msize >= 4096

2020-01-16 Thread Greg Kurz
On Mon, 13 Jan 2020 23:21:04 +0100 Christian Schoenebeck wrote: > A client establishes a session by sending a Tversion request along with > a 'msize' parameter which client uses to suggest server a maximum > message size ever to be used for communication (for both requests and > replies) between

[PATCH v3 02/11] 9pfs: require msize >= 4096

2020-01-13 Thread Christian Schoenebeck
A client establishes a session by sending a Tversion request along with a 'msize' parameter which client uses to suggest server a maximum message size ever to be used for communication (for both requests and replies) between client and server during that session. If client suggests a 'msize' smalle