Re: [PATCH v3 06/44] qemu-option: Check return value instead of @err where convenient

On Mon, 06 Jul 2020 22:01:38 +0200 Markus Armbruster wrote: > Greg Kurz writes: > > > On Mon, 6 Jul 2020 10:09:12 +0200 > > Markus Armbruster wrote: > > > >> Convert uses like > >> > >> opts = qemu_opts_create(..., ); > >> if (err) { > >> ... > >> } > >> > >> to > >> >

Re: [PATCH v3 06/44] qemu-option: Check return value instead of @err where convenient

Greg Kurz writes: > On Mon, 6 Jul 2020 10:09:12 +0200 > Markus Armbruster wrote: > >> Convert uses like >> >> opts = qemu_opts_create(..., ); >> if (err) { >> ... >> } >> >> to >> >> opts = qemu_opts_create(..., ); > > The patch doesn't strictly do that since it also

Re: [PATCH v3 06/44] qemu-option: Check return value instead of @err where convenient

On Mon, 6 Jul 2020 10:09:12 +0200 Markus Armbruster wrote: > Convert uses like > > opts = qemu_opts_create(..., ); > if (err) { > ... > } > > to > > opts = qemu_opts_create(..., ); The patch doesn't strictly do that since it also converts to errp. This is okay

[PATCH v3 06/44] qemu-option: Check return value instead of @err where convenient

Convert uses like opts = qemu_opts_create(..., ); if (err) { ... } to opts = qemu_opts_create(..., ); if (!opts) { ... } Eliminate error_propagate() that are now unnecessary. Delete @err that are now unused. Signed-off-by: Markus Armbruster