Re: [PATCH v3 08/10] target/riscv: Consolidate RV32/64 32-bit instructions

2021-04-25 Thread Alistair Francis
On Mon, Apr 26, 2021 at 9:53 AM Richard Henderson wrote: > > On 4/25/21 3:58 PM, Alistair Francis wrote: > > On Sun, Apr 25, 2021 at 3:08 AM Richard Henderson > > wrote: > >> > >> On 4/23/21 8:34 PM, Alistair Francis wrote: > >>> --- a/target/riscv/translate.c > >>> +++

Re: [PATCH v3 08/10] target/riscv: Consolidate RV32/64 32-bit instructions

2021-04-25 Thread Richard Henderson
On 4/25/21 3:58 PM, Alistair Francis wrote: On Sun, Apr 25, 2021 at 3:08 AM Richard Henderson wrote: On 4/23/21 8:34 PM, Alistair Francis wrote: --- a/target/riscv/translate.c +++ b/target/riscv/translate.c @@ -74,8 +74,6 @@ static inline bool has_ext(DisasContext *ctx, uint32_t ext)

Re: [PATCH v3 08/10] target/riscv: Consolidate RV32/64 32-bit instructions

2021-04-25 Thread Alistair Francis
On Sun, Apr 25, 2021 at 3:08 AM Richard Henderson wrote: > > On 4/23/21 8:34 PM, Alistair Francis wrote: > > --- a/target/riscv/translate.c > > +++ b/target/riscv/translate.c > > @@ -74,8 +74,6 @@ static inline bool has_ext(DisasContext *ctx, uint32_t > > ext) > > > > #ifdef TARGET_RISCV32 > >

Re: [PATCH v3 08/10] target/riscv: Consolidate RV32/64 32-bit instructions

2021-04-24 Thread Richard Henderson
On 4/23/21 8:34 PM, Alistair Francis wrote: --- a/target/riscv/translate.c +++ b/target/riscv/translate.c @@ -74,8 +74,6 @@ static inline bool has_ext(DisasContext *ctx, uint32_t ext) #ifdef TARGET_RISCV32 # define is_32bit(ctx) true -#elif defined(CONFIG_USER_ONLY) -# define

[PATCH v3 08/10] target/riscv: Consolidate RV32/64 32-bit instructions

2021-04-23 Thread Alistair Francis
This patch removes the insn32-64.decode decode file and consolidates the instructions into the general RISC-V insn32.decode decode tree. This means that all of the instructions are avaliable in both the 32-bit and 64-bit builds. This also means that we run a check to ensure we are running a