Re: [PATCH v3 09/30] target/mips: Merge do_translate_address into cpu_mips_translate_address

2021-04-19 Thread Richard Henderson
On 4/19/21 12:18 PM, Philippe Mathieu-Daudé wrote: Currently cpu_mips_translate_address() calls raise_mmu_exception(), and do_translate_address() calls cpu_loop_exit_restore(). This API split is dangerous, we could call cpu_mips_translate_address without returning to the main loop. As there is

[PATCH v3 09/30] target/mips: Merge do_translate_address into cpu_mips_translate_address

2021-04-19 Thread Philippe Mathieu-Daudé
Currently cpu_mips_translate_address() calls raise_mmu_exception(), and do_translate_address() calls cpu_loop_exit_restore(). This API split is dangerous, we could call cpu_mips_translate_address without returning to the main loop. As there is only one caller, it is trivial (and safer) to merge d