Re: [PATCH v3 1/2] Introduce (x86) CPU model deprecation API

2020-09-21 Thread Robert Hoo
On Mon, 2020-09-21 at 11:37 -0400, Eduardo Habkost wrote: > > ... > > Yes. Trying as less refactor as possible. I think my changes even > > cannot be called refactor at all. :) > > My idea is to make unversioned CPU model virtual. I did some patch, > > doable: > > 1) in

Re: [PATCH v3 1/2] Introduce (x86) CPU model deprecation API

2020-09-21 Thread Eduardo Habkost
On Sat, Sep 19, 2020 at 11:22:12AM +0800, Robert Hoo wrote: > On Fri, 2020-09-18 at 16:42 +, Eduardo Habkost wrote: > > ... > > > > > --- > > > > > Changelog > > > > > v3: > > > > > Make the deprecation implementation CPUClass generic. > > > > > > > > > > v2: > > > > > Move deprecation check

Re: [PATCH v3 1/2] Introduce (x86) CPU model deprecation API

2020-09-18 Thread Robert Hoo
On Fri, 2020-09-18 at 16:42 +, Eduardo Habkost wrote: > ... > > > > --- > > > > Changelog > > > > v3: > > > > Make the deprecation implementation CPUClass generic. > > > > > > > > v2: > > > > Move deprecation check from parse_cpu_option() to > > > > machine_run_board_init(), so > > > > that

Re: [PATCH v3 1/2] Introduce (x86) CPU model deprecation API

2020-09-18 Thread Eduardo Habkost
On Fri, Sep 18, 2020 at 01:48:18PM +0800, Robert Hoo wrote: > On Thu, 2020-09-17 at 14:18 -0400, Eduardo Habkost wrote: > > I think the patch looks better now, thanks! > > > > Just a few minor questions and suggestions: > > > > On Wed, Sep 16, 2020 at 04:37:13PM +0800, Robert Hoo wrote: > > >

Re: [PATCH v3 1/2] Introduce (x86) CPU model deprecation API

2020-09-17 Thread Robert Hoo
On Thu, 2020-09-17 at 14:18 -0400, Eduardo Habkost wrote: > I think the patch looks better now, thanks! > > Just a few minor questions and suggestions: > > On Wed, Sep 16, 2020 at 04:37:13PM +0800, Robert Hoo wrote: > > Complement versioned CPU model framework with the ability of > > marking

Re: [PATCH v3 1/2] Introduce (x86) CPU model deprecation API

2020-09-17 Thread Eduardo Habkost
I think the patch looks better now, thanks! Just a few minor questions and suggestions: On Wed, Sep 16, 2020 at 04:37:13PM +0800, Robert Hoo wrote: > Complement versioned CPU model framework with the ability of marking some > versions deprecated. When that CPU model is chosen, get some warning.

[PATCH v3 1/2] Introduce (x86) CPU model deprecation API

2020-09-16 Thread Robert Hoo
Complement versioned CPU model framework with the ability of marking some versions deprecated. When that CPU model is chosen, get some warning. The warning message is customized, e.g. telling in which future QEMU version will it be obsoleted. The deprecation message will also appear by