Re: [PATCH v3 1/4] qapi: Add a 'coroutine' flag for commands

2020-01-17 Thread Kevin Wolf
Am 17.01.2020 um 11:43 hat Markus Armbruster geschrieben: > Kevin Wolf writes: > > > Am 17.01.2020 um 08:57 hat Markus Armbruster geschrieben: > >> Kevin Wolf writes: > >> > >> > Am 16.01.2020 um 14:00 hat Markus Armbruster geschrieben: > >> >> Kevin Wolf writes: > >> >> > I have no idea if we

Re: [PATCH v3 1/4] qapi: Add a 'coroutine' flag for commands

2020-01-17 Thread Markus Armbruster
Kevin Wolf writes: > Am 17.01.2020 um 08:57 hat Markus Armbruster geschrieben: >> Kevin Wolf writes: >> >> > Am 16.01.2020 um 14:00 hat Markus Armbruster geschrieben: >> >> Kevin Wolf writes: >> >> > I have no idea if we will eventually get a case where the command wants >> >> > to behave diff

Re: [PATCH v3 1/4] qapi: Add a 'coroutine' flag for commands

2020-01-17 Thread Kevin Wolf
Am 17.01.2020 um 08:57 hat Markus Armbruster geschrieben: > Kevin Wolf writes: > > > Am 16.01.2020 um 14:00 hat Markus Armbruster geschrieben: > >> Kevin Wolf writes: > >> > I have no idea if we will eventually get a case where the command wants > >> > to behave different between the two modes a

Re: [PATCH v3 1/4] qapi: Add a 'coroutine' flag for commands

2020-01-16 Thread Markus Armbruster
Kevin Wolf writes: > Am 16.01.2020 um 14:00 hat Markus Armbruster geschrieben: >> Kevin Wolf writes: >> > I have no idea if we will eventually get a case where the command wants >> > to behave different between the two modes and actually has use for a >> > coroutine. I hope not. >> > >> > But us

Re: [PATCH v3 1/4] qapi: Add a 'coroutine' flag for commands

2020-01-16 Thread Markus Armbruster
Markus Armbruster writes: > Kevin Wolf writes: > >> Am 15.01.2020 um 15:59 hat Markus Armbruster geschrieben: >>> Kevin Wolf writes: >>> >>> > This patch adds a new 'coroutine' flag to QMP command definitions that >>> > tells the QMP dispatcher that the command handler is safe to be run in a >

Re: [PATCH v3 1/4] qapi: Add a 'coroutine' flag for commands

2020-01-16 Thread Kevin Wolf
Am 16.01.2020 um 14:00 hat Markus Armbruster geschrieben: > Kevin Wolf writes: > > I have no idea if we will eventually get a case where the command wants > > to behave different between the two modes and actually has use for a > > coroutine. I hope not. > > > > But using two bools rather than a s

Re: [PATCH v3 1/4] qapi: Add a 'coroutine' flag for commands

2020-01-16 Thread Markus Armbruster
Kevin Wolf writes: > Am 15.01.2020 um 15:59 hat Markus Armbruster geschrieben: >> Kevin Wolf writes: >> >> > This patch adds a new 'coroutine' flag to QMP command definitions that >> > tells the QMP dispatcher that the command handler is safe to be run in a >> > coroutine. >> > >> > Signed-off-

Re: [PATCH v3 1/4] qapi: Add a 'coroutine' flag for commands

2020-01-15 Thread Kevin Wolf
Am 15.01.2020 um 15:59 hat Markus Armbruster geschrieben: > Kevin Wolf writes: > > > This patch adds a new 'coroutine' flag to QMP command definitions that > > tells the QMP dispatcher that the command handler is safe to be run in a > > coroutine. > > > > Signed-off-by: Kevin Wolf > > Reviewed-b

Re: [PATCH v3 1/4] qapi: Add a 'coroutine' flag for commands

2020-01-15 Thread Markus Armbruster
Kevin Wolf writes: > This patch adds a new 'coroutine' flag to QMP command definitions that > tells the QMP dispatcher that the command handler is safe to be run in a > coroutine. > > Signed-off-by: Kevin Wolf > Reviewed-by: Marc-André Lureau > --- > tests/qapi-schema/qapi-schema-test.json |

[PATCH v3 1/4] qapi: Add a 'coroutine' flag for commands

2020-01-15 Thread Kevin Wolf
This patch adds a new 'coroutine' flag to QMP command definitions that tells the QMP dispatcher that the command handler is safe to be run in a coroutine. Signed-off-by: Kevin Wolf Reviewed-by: Marc-André Lureau --- tests/qapi-schema/qapi-schema-test.json | 1 + docs/devel/qapi-code-gen.txt