Re: [PATCH v3 12/13] hw/arm/raspi: Use a unique raspi_machine_class_init() method

2020-02-15 Thread Philippe Mathieu-Daudé
On Thu, Feb 13, 2020 at 3:16 PM Philippe Mathieu-Daudé wrote: > On 2/13/20 2:59 PM, Peter Maydell wrote: > > On Sat, 8 Feb 2020 at 16:57, Philippe Mathieu-Daudé wrote: > >> > >> With the exception of the ignore_memory_transaction_failures > >> flag set for the raspi2, both machine_class_init()

Re: [PATCH v3 12/13] hw/arm/raspi: Use a unique raspi_machine_class_init() method

2020-02-13 Thread Philippe Mathieu-Daudé
On 2/13/20 3:32 PM, Peter Maydell wrote: On Thu, 13 Feb 2020 at 14:16, Philippe Mathieu-Daudé wrote: On 2/13/20 2:59 PM, Peter Maydell wrote: The natural way to implement this is to have the .class_data be a pointer to a struct which is in an array and defines relevant per-class stuff, the

Re: [PATCH v3 12/13] hw/arm/raspi: Use a unique raspi_machine_class_init() method

2020-02-13 Thread Peter Maydell
On Thu, 13 Feb 2020 at 14:16, Philippe Mathieu-Daudé wrote: > On 2/13/20 2:59 PM, Peter Maydell wrote: > > The natural way to implement this is to have the .class_data > > be a pointer to a struct which is in an array and defines > > relevant per-class stuff, the same way we do in > >

Re: [PATCH v3 12/13] hw/arm/raspi: Use a unique raspi_machine_class_init() method

2020-02-13 Thread Philippe Mathieu-Daudé
On 2/13/20 2:59 PM, Peter Maydell wrote: On Sat, 8 Feb 2020 at 16:57, Philippe Mathieu-Daudé wrote: With the exception of the ignore_memory_transaction_failures flag set for the raspi2, both machine_class_init() methods are now identical. Merge them to keep a unique method. Signed-off-by:

Re: [PATCH v3 12/13] hw/arm/raspi: Use a unique raspi_machine_class_init() method

2020-02-13 Thread Peter Maydell
On Sat, 8 Feb 2020 at 16:57, Philippe Mathieu-Daudé wrote: > > With the exception of the ignore_memory_transaction_failures > flag set for the raspi2, both machine_class_init() methods > are now identical. Merge them to keep a unique method. > > Signed-off-by: Philippe Mathieu-Daudé > --- >

Re: [PATCH v3 12/13] hw/arm/raspi: Use a unique raspi_machine_class_init() method

2020-02-10 Thread Igor Mammedov
On Sat, 8 Feb 2020 17:56:44 +0100 Philippe Mathieu-Daudé wrote: > With the exception of the ignore_memory_transaction_failures > flag set for the raspi2, both machine_class_init() methods > are now identical. Merge them to keep a unique method. > > Signed-off-by: Philippe Mathieu-Daudé

[PATCH v3 12/13] hw/arm/raspi: Use a unique raspi_machine_class_init() method

2020-02-08 Thread Philippe Mathieu-Daudé
With the exception of the ignore_memory_transaction_failures flag set for the raspi2, both machine_class_init() methods are now identical. Merge them to keep a unique method. Signed-off-by: Philippe Mathieu-Daudé --- hw/arm/raspi.c | 31 ++- 1 file changed, 6